Skip to content

Fix quick view tooltip loading overlay offset#3407

Merged
yadvr merged 1 commit into
apache:masterfrom
NicoWohlfarth:fix_quick_view_tooltip_loading_overlay
Jun 18, 2019
Merged

Fix quick view tooltip loading overlay offset#3407
yadvr merged 1 commit into
apache:masterfrom
NicoWohlfarth:fix_quick_view_tooltip_loading_overlay

Conversation

@NicoWohlfarth
Copy link
Copy Markdown
Contributor

Description

Fixed the styling of the quick view tooltip loading overlay. Before it would have a top offset to the quick view tooltip and stick out of the tooltip. Afterwards it just overlays the tooltip.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots:

Before:
CS1
After:
CS2

How Has This Been Tested?

Deployed to local environment and tested functionality.

@DennisKonrad DennisKonrad requested a review from yadvr June 17, 2019 11:11
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not test it.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jun 17, 2019

This is ready for merge as soon as someone can confirm manual test as this is purely UI change.

@yadvr yadvr added this to the 4.13.0.0 milestone Jun 17, 2019
@svenvogel
Copy link
Copy Markdown
Contributor

@anuragaw @shwstppr can you take a look? 👍

Copy link
Copy Markdown
Contributor

@anuragaw anuragaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, working. LGTM!

@yadvr yadvr merged commit 0886c0c into apache:master Jun 18, 2019
@NicoWohlfarth NicoWohlfarth deleted the fix_quick_view_tooltip_loading_overlay branch June 19, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants