[UI] Improve visibility of dropdown menus on dialogs#3528
Merged
Conversation
Contributor
Author
Contributor
Author
|
@blueorangutan package |
|
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-195 |
yadvr
approved these changes
Jul 29, 2019
Member
|
UI only change, after manual test/verification we can merge. cc @borisstoyanov @andrijapanic |
anuragaw
approved these changes
Jul 30, 2019
Contributor
anuragaw
left a comment
anuragaw
left a comment
There was a problem hiding this comment.
LGTM!
Even though this change would be reflected in all of UI and not just the domain list but it is the right change.
anuragaw
reviewed
Jul 30, 2019
Contributor
anuragaw
left a comment
anuragaw
left a comment
There was a problem hiding this comment.
Manually tested locally on KVM Environment that long zone names are indeed scrollable and readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It was not possible to display the entire name of items in dropdown menus within dialogs in CloudStack, such as:
Types of changes
Screenshots (if appropriate):
Before this fix, the entire name of the menu items were not entirely displayed:
Scrolling option is added, preserving the dialog's original width:
How Has This Been Tested?
Test CloudStack dialogs with dropdown menus