ui: fix for custom constrained offering params range check#3545
Merged
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Contributor
Author
|
@borisstoyanov @andrijapanicsb @anuragaw @rhtyd @svenvogel |
yadvr
approved these changes
Aug 7, 2019
Contributor
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-231 |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Contributor
Author
|
@blueorangutan package |
|
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-232 |
borisstoyanov
approved these changes
Aug 7, 2019
Contributor
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, just verified it manually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes range check in VM deployment wizard while using custom constrained offering.
Existing code was failing while checking user input value in the form for CPU cores and RAM size when minimum and maximum value vary in digit count.
Also, while re-selecting offerings slider position was not restored to minimum value. THis has been fixed with changes.
Types of changes
Screenshots (if appropriate):
Entering a valid value for RAM but getting error,
Selecting custom constrained offering initially, then making changes for CPU, RAM parameters, then selecting a fixed offering and then again selecting custom constrained offering. Though text input shows minimum values but slider is not at the start.
How Has This Been Tested?
UI