Skip to content

add vSphere 6.7.3 and update 6.7.2 & 6.7.1#3564

Merged
PaulAngus merged 2 commits into
apache:masterfrom
shapeblue:vSphere
Aug 20, 2019
Merged

add vSphere 6.7.3 and update 6.7.2 & 6.7.1#3564
PaulAngus merged 2 commits into
apache:masterfrom
shapeblue:vSphere

Conversation

@PaulAngus
Copy link
Copy Markdown
Member

@PaulAngus PaulAngus commented Aug 18, 2019 •
edited by yadvr
Loading

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@PaulAngus PaulAngus added this to the 4.13.0.0 milestone Aug 18, 2019
yadvr
yadvr reviewed Aug 19, 2019
View reviewed changes
Comment thread engine/schema/src/main/resources/META-INF/db/schema-41200to41300.sql
yadvr
yadvr approved these changes Aug 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a minor remark.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 19, 2019

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 19, 2019

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 19, 2019

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-260

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 19, 2019

@blueorangutan test centos7 vmware-65u2

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 19, 2019

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 19, 2019

Trillian test result (tid-329)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31850 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3564-t329-vmware-65u2.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 19, 2019

Test LGTM, let's review and merge need another +1/lgtm - @borisstoyanov @andrijapanicsb

borisstoyanov
borisstoyanov approved these changes Aug 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on review and marvin test results.

@PaulAngus PaulAngus merged commit 77f9ab2 into apache:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@nvazquez nvazquez Awaiting requested review from nvazquez

@andrijapanicsb andrijapanicsb Awaiting requested review from andrijapanicsb

Assignees

No one assigned

Labels

component:vmware type:enhancement

Projects

None yet

Milestone

4.13.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@PaulAngus @yadvr @blueorangutan @borisstoyanov @svenvogel