Unable to deploy VMs via UI in advanced networks with SG and IPv6 cidr

[GabrielBrascher]

Description

When deploying a VM via UI, networks that have all the following characteristics are not listed on the wizard:

• advanced networking with security groups
• traffic type of "Guest"
• guest type of "Shared"
• IPv6 CIDR not null

This PR fixes it by removing the verification that counts the IPs from UserIpv6AddressVO in order to check if it can use the network for deploying new VMs in UI [1]. Table "user_ipv6_address" (UserIpv6AddressVO) is empty and will always be as it is a legacy code/table, not used in any IP
allocation flow. Therefore, the removed verification should be removed.

[1] com.cloud.network.NetworkModelImpl.canUseForDeploy(Network)

This PR fixes #3570

Why it happens

The Javascript code adds the parameter canusefordeploy=true on the API call when the network is an advanced network with security groups. With that, the endpoint (management server) expects "canUseForDeploy" to be true; however, the returned value is false due to not finding IPv6 addresses available in the network, which makes the UI to not list those networks.

#3569 IPv6 code cleanup: several PRs will be created in the near future aiming a complete cleanup on IPv6 code in order to avoid such mistakes to repeat

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases

[wido]

LGTM

With IPv6 we do not need to track free IPs. Everything is calculated based on MAC and CIDR.

[PaulAngus]

@blueorangutan package

[blueorangutan]

@PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-266

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-343)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36871 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3571-t343-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[PaulAngus]

Merging based on 2x LGTM and 0 errors in regression smoke tests