kvm: Use 'ip' instead of 'brctl'

[wido]

The command 'brctl' is deprecated and should no longer be used.

iproute2 supports all the features we need and therefor we should use
this instead of the old commands.

Feature wise this does not change anything. It just makes the code more
robust towards the future.

Signed-off-by: Wido den Hollander wido@widodh.nl

[ustcweizhou]

LGTM
tested the commands on ubuntu 16

[RPDiep]

Seems good to me, except this won't run under CentOS 6 according to the manpages of iproute (running currently iproute 2.6.32).
Backporting this should therefore not be done.

[yadvr]

@wido can you also fix scripts/vm/network/vnet/modifyvlan.sh?
With CentOS6 support removed from master/4.14, we should try and move all network related commands to use iproute2 instead of ifconfig/brctl etc.

[wido]

Done @rhtyd

[yadvr]

Nice, thanks.

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-310

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GabrielBrascher]

LGTM

[GabrielBrascher]

This one looks ready to merge.
@rhtyd Is there any issue with the blueorangutan test?

[yadvr]

Something went wrong at the backend, I'll rekick test.
@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-324

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-422)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36375 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3623-t422-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	Failure	244.80	test_privategw_acl.py