Skip to content

New BuildRequires for CentOS 7: python-setuptools#3630

Merged
yadvr merged 1 commit into
masterfrom
unknown repository
Nov 21, 2019
Merged

New BuildRequires for CentOS 7: python-setuptools#3630
yadvr merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 9, 2019

(It's already added for debian)

Signed-off-by: Kai Takahashi www.carrotsoft@gmail.com

Description

Add python-setuptools as a build-time dependency package for CentOS 7.
python-setuptools is already added as a dependency package for debian from commit 4a77a799490a0cd655b1a53377c4db1bb51ddc7c

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

(It's already added for debian from
commit 4a77a79)

Signed-off-by: Kai Takahashi <www.carrotsoft@gmail.com>
@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 9, 2019

Without python-setuptools, building cloudstack fails.

cp: cannot stat 'tools/marvin/dist/Marvin-*.tar.gz': No such file or directory

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Oct 10, 2019

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr yadvr added this to the 4.14.0.0 milestone Oct 10, 2019
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, subject to packaging

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-312

Copy link
Copy Markdown
Contributor

@svenvogel svenvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since CentOS 7.7 i think we need it.

@yadvr yadvr merged commit fc9a525 into apache:master Nov 21, 2019
ustcweizhou pushed a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
(It's already added for debian from
commit 4a77a79)

Signed-off-by: Kai Takahashi <www.carrotsoft@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants