convert protocol names to be found as labels#3725
Closed
DaanHoogland wants to merge 1 commit into
Closed
Conversation
DaanHoogland
changed the title
Contributor
Author
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-407 |
Contributor
Author
|
reviewers please consider if this is for the right milestone. |
Contributor
Author
|
needs to be on 4.13?? |
Member
|
@DaanHoogland If we consider it as a bug then it makes sense to have it fixed on 4.13.1.0. However, if it is considered an enhancement then I don't see why not keeping the 4.14 milestone. Looking at #3252 I would consider it as a bug on the UI; +1 on setting it to branch 4.13 and milestone 4.13.1.0. |
Contributor
Author
|
rebasing on 4.13 in #3747 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
replace significant chars from string to find protocol labels
Fixes: #3252
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?