config: add isdynamic flag in configuration response#3729
Conversation
|
@blueorangutan package |
|
thx Wei. |
GabrielBrascher
left a comment
GabrielBrascher
left a comment
There was a problem hiding this comment.
Code LGTM. Thanks @ustcweizhou :)
|
@blueorangutan package |
|
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-412 |
|
LGTM Tested manually on 10-15 different settings. |
|
This will largely work for most global settings, however, there are configkeys that are defined to not be dynamic in nature and sometimes configkey which are are dynamic are used while creating a scheduled thread or executor service whose values only apply when a cloudstack component (managerbase etc.) is configured but not during/after the component has started. To accept this, will require codebase wide search and changing any configkeys which are declared as dynamic but not used dynamically. |
|
@rhtyd |
|
good catch @rhtyd , however, will this be harmful? Or can we merge and plan the small fixes that will follow as they come up? |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✖centos7 ✔debian. JID-440 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✖centos7 ✔debian. JID-444 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-461 |
|
cc @PaulAngus this adds feature to know if restarting mgmt server is needed after updating a global setting. I'll see what we can do to detect/fix this in Primate. |
|
discussed with @Rohit offline. this is a significant improvement over the current situation in spite of his remarks. We'll need to deal with the 10% of exceptions as we encounter them. |
* create template from snapshot regression (partly reverted) (#3767) * Once again allow a VM to be on multiple networks from VPCs (#3754) to once again allow a VM to be on multiple networks from VPCs * convert protocal names to be found as labels (#3747) * convert protocal names to be found as labels * format * filter hosts to query on zone wide storage (#3733) * config: add isdynamic flag in configuration response (#3729) Co-authored-by: Wei Zhou <ustcweizhou@gmail.com>
* 4.13: Added zone check for attach iso (#3755) config: add isdynamic flag in configuration response (#3729) filter hosts to query on zone wide storage (#3733) convert protocal names to be found as labels (#3747) Once again allow a VM to be on multiple networks from VPCs (#3754) create template from snapshot regression (partly reverted) (#3767)
8 participants
Description
Some configurations are dynamic so it does not require restart of mgt server when we change it.
Add isdynamic in configuration response, and does not pop up dialog "restart mgt server" if config is dynamic on UI.
Fixes: #3683
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Tested with global configuration "xen.vm.vcpu.max", it works fine (no pop up dialog).