server: fix resource count error when upgrade a vm

[ustcweizhou]

Description

Steps to reproduce the issue
(1) create an account (test)
(2) create a vm with the account (test)
(3) login with admin, and upgrade the vm to another offering
(4) the resource count (cpu,memory) of admin increases, not the account (test).

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

[DaanHoogland]

makes a lot of sense. code looks good

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-639

[DennisKonrad]

@ustcweizhou I tried to recreate the bug with current master in a testenvironment. Are the any Domains, Projects or something else involved?

Just creating another user with an vm and increasing the VM ressources with admin did not show the bug.
I checked the resourcecount via api with
update resourcecount domainid=xxxxx account=testuser
and it showed the right counts.

If I can recreate the bug I can review your PR.

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-808)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30995 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3759-t808-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[weizhouapache]

@ustcweizhou I tried to recreate the bug with current master in a testenvironment. Are the any Domains, Projects or something else involved?

Just creating another user with an vm and increasing the VM ressources with admin did not show the bug.
I checked the resourcecount via api with
update resourcecount domainid=xxxxx account=testuser
and it showed the right counts.

If I can recreate the bug I can review your PR.

@DennisKonrad thanks for testing.
update resource count will recalculate the resource count and update database if count is not same so the value in response is always correct.

However the count is not correct if we use listDomains or listAccounts before updateresourcecount.

[DaanHoogland]

thanks @DennisKonrad , can you review,test and/or confirm that this fixes the bug or at least is an improvement? (this need a second 👍 )

[DennisKonrad]

@ustcweizhou @DaanHoogland I was able to reproduce the bug (on current master) and this PR fixes the issue. So LGTM