Agent lb on svm

[DaanHoogland]

Description

If a host is not in the list of hosts and an agent load balancing list is required for it, add it to the list to get a valid MSlist.

Fixes: #3722

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-539

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-707)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37015 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3795-t707-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_redundant_vpc_site2site_vpn	Failure	276.27	test_vpc_vpn.py

[yadvr]

LGTM, did not test it. Requested some changes.

[yadvr]

@DaanHoogland replied, let me know if I've anything else.

[DaanHoogland]

ping @andrijapanicsb this can do with a second pair of eyes and some tests

[andrijapanicsb]

@blueorangutan package

[blueorangutan]

@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-595

[andrijapanicsb]

Tested manually by reproducing the issue on clean 4.13, confirming CPVM won't start with the exceptions below...:

2020-01-14 14:02:44,379 DEBUG [c.c.a.ConsoleProxyAlertAdapter] (consoleproxy-1:ctx-a32cef4f) (logid:5d7a9f58) received console proxy alert
2020-01-14 14:02:44,380 DEBUG [c.c.a.ConsoleProxyAlertAdapter] (consoleproxy-1:ctx-a32cef4f) (logid:5d7a9f58) Console proxy creation failure, zone: ref-trl-451-x-M7-apanic
2020-01-14 14:02:44,381 WARN [c.c.a.AlertManagerImpl] (consoleproxy-1:ctx-a32cef4f) (logid:5d7a9f58) AlertType:: 10 | dataCenterId:: 1 | podId:: null | clusterId:: null | message:: Console proxy creation failure. zone: ref-trl-451-x-M7-apanic, error details: fromIndex = -1
2020-01-14 14:02:44,387 WARN [c.c.v.SystemVmLoadScanner] (consoleproxy-1:ctx-a32cef4f) (logid:5d7a9f58) Unexpected exception fromIndex = -1
java.lang.IndexOutOfBoundsException: fromIndex = -1
at java.util.SubList.(AbstractList.java:620)
at java.util.RandomAccessSubList.(AbstractList.java:775)

Upgrade to this one, and CPVM starts fine (part of output below):

2020-01-14 14:35:16,100 DEBUG [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-1:ctx-a2d2a0b1 job-5/job-160 ctx-0562c679) (logid:8ae77e28) Successfully transitioned to start state for VM[ConsoleProxy|v-3-VM] reservation id = 44c9f85a-3c14-474f-93a6-8cfdd2fdc0d3

[andrijapanicsb]

LGTM