Incorrect param name caused global setting test to fail#3821
Merged
Conversation
anuragaw
changed the title
yadvr
approved these changes
Jan 20, 2020
Contributor
|
@rhtyd is the status of this testing? and you added milestone for 4.14, not valid for 4.13? |
5 tasks
DaanHoogland
approved these changes
Jan 24, 2020
|
|
||
| listConfigurationsCmd = listConfigurations.listConfigurationsCmd() | ||
| listConfigurationsCmd.cfgName = updateConfigurationResponse.name | ||
| listConfigurationsCmd.name = updateConfigurationResponse.name |
Contributor
There was a problem hiding this comment.
wow, that line is from 2013. no one noticed?
Contributor
|
2 lgtm and fixed test is executed in travis successfully, merging |
DaanHoogland
changed the title
ustcweizhou
pushed a commit
to ustcweizhou/cloudstack
that referenced
this pull request
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Causes failure in travis. The incorrect param was returning no value back and causing test to fail.
Description
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Ran the Marvin test locally on CentOS based monkeybox env and verified test failed without change and succeeded with change.