set TCP as default protocol in lb list#3822
Merged
Merged
Conversation
Contributor
Author
|
Can be tested by downloading the patch file to mgmt server https://github.com/apache/cloudstack/commit/b9f39757506e0831ebcf015c408f6e93f7198c0d.patch cd /usr/share/cloudstack-management/webapp/scripts |
yadvr
approved these changes
Jan 20, 2020
Member
yadvr
left a comment
yadvr
left a comment
There was a problem hiding this comment.
LGTM, I'll incorporate the same in Primate as well.
Contributor
|
@andrijapanicsb not for 4.13? (lgtm otherwise) |
Contributor
Author
|
not in 4.13 as its not a bug fix @dahn. Merging based on 2 LGTMs and manual testing. Automated testing not needed as this is a simple JS change. |
ustcweizhou
pushed a commit
to ustcweizhou/cloudstack
that referenced
this pull request
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of "SSL" being set as a default LB protocol when configuring a LB rule, set TCP as the default one - move SSL to the bottom of the list.
Reason: SSL is supported only with NetScaller and should not even be there if VPC is not using NetScaller for LB services... so stop offering it as the default protocol and confusing VPC VR (i.e. non-NesScaller) users
Types of changes
Screenshots (if appropriate):
Old setup:
New setup:
