systemvm: list systemvm does not return agent state and version

[yadvr]

This makes the listSystemVms API to return the host status (agent state),
version and last pinged information. This makes it possible for UIs
to call a single API to get this information.

This is largely for Primate.

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-777

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yadvr]

@shwstppr @Pearl1594 please review as well.

[Pearl1594]

LGTM - agentstate, lastpinged and version fields seem to be added to the list systemvms response

[DaanHoogland]

code lgtm. seems like an enhancement to me. Primate targets 4.15, should we put it in here?

[shwstppr]

can we add since key here as these are new response params

[shwstppr]

LGTM

[yadvr]

@DaanHoogland the technical preview targets 4.14, without this fix the implementation in Primate would be complicated.

[weizhouapache]

code LGTM

@rhtyd can you make some changes on 4.13/4.14 UI ? the agent state is determined in a complicated way.

[yadvr]

That's not very critical, but let me check if it's a quick one. I originally wanted to limit the scope just to apis, wrt Primate.

[DaanHoogland]

ok, @rhtyd I'm fine with it. merge at will.

[yadvr]

@shwstppr thanks, fixed the since in params response keys.
@weizhouapache I've fixed the UI as well. Can you review and test the API/UI changes? Thanks.

[yadvr]

Thanks @DaanHoogland will merge after smoketests and some UI confirmation (cc @weizhouapache)
@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-784

[DaanHoogland]

@weizhouapache can you confirm the ui?

[weizhouapache]

@DaanHoogland ui works.

However, lastping returns wrong date/time. we have same issue on other api response. we can fix them together afterwards.
@DaanHoogland
(1)we have "System.currentTimeMillis() >> 10" in many files, should it be "System.currentTimeMillis() / 1000" ?
(2) considering lastPing saves the timestamp in seconds, we need to display date by "new Date(timestamp * 1000)". If we do not change the ">>10" to 1000, we should use 1024 here.

[DaanHoogland]

sounds like a ugly bug @weizhouapache shift by ten bits != /1000. I think we should move away from the bit shifting when dealing with milliseconds.
Would you consider this not to be a blocker for this PR?

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yadvr]

@weizhouapache cc @DaanHoogland I used the same logic as here: https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java#L105

[weizhouapache]

@DaanHoogland what I said is not a blocker. I am ok with this PR.

@rhtyd yes, it has same issue. In response of listhosts and listsystemvms, both shows the last ping time is "1970-01-XXXX" instead of "2020-02-XXXX". we can fix it in the future, not today.