Fixed root volume resize from ui

[Spaceman1984]

Description

This PR fixes the volume resize action for a root volume from the UI.

Fixes: #3860 #3874

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

This has been tested by creating an instance and resizing the root volume. The root volume size is then verified in storage metrics.

[Spaceman1984]

@blueorangutan package

[blueorangutan]

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-788

[Spaceman1984]

@blueorangutan test

[blueorangutan]

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-933)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36730 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3873-t933-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	Failure	215.15	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	213.78	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Failure	317.99	test_privategw_acl.py

[Spaceman1984]

@blueorangutan package

[weizhouapache]

@Spaceman1984
I have tested it ,it works.

however, I think we can use the following change on line 1578

if (selectedDiskOfferingObj == null || selectedDiskOfferingObj.iscustomized == true) {

the change on line 1597-1601 are not needed then.

the change on line 1584 are needed.

[Spaceman1984]

@Spaceman1984
I have tested it ,it works.

however, I think we can use the following change on line 1578

if (selectedDiskOfferingObj == null || selectedDiskOfferingObj.iscustomized == true) {

the change on line 1597-1601 are not needed then.

the change on line 1584 are needed.

@weizhouapache
I agree with all, accept, I think line 1601 can be removed, but we need to keep line 1597-1600 - it's an error message about not allowing a smaller volume size. - Ok, I think I know what you mean. If I revert that change, it would be the same, except for the initial newSize variable that didn't exist.

[Spaceman1984]

All good @weizhouapache, I will make those changes.

[Spaceman1984]

@blueorangutan package

[blueorangutan]

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[borisstoyanov]

@blueorangutan package

[blueorangutan]

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-797

[Spaceman1984]

@blueorangutan package

[blueorangutan]

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-800

[Spaceman1984]

@blueorangutan package

[blueorangutan]

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-801

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[borisstoyanov]

LGTM, manually verified it works

[borisstoyanov]

I guess we could merge this one as it does not require marvin tests (UI fix).

[blueorangutan]

Packaging result: ✖centos6 ✖centos7 ✔debian. JID-823