Look for active templates for VR deployment by ravening · Pull Request #4047 · apache/cloudstack

ravening · 2020-04-28T15:06:04Z

Description

If the template from which VR is created got deleted, the state
is set to inactive and removed to null.
Since the template is already deleted, the VR can't be created
using this template again.

If someone restarts network with cleanup then it will try to
deploy the vr from the old non existing template again.
So search only for active template which are not yet deleted.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Create a network and this will in turn create VR's
Note down the template from which the VR was created
Delete that template
Now restart the network with cleanup option
The new router deployment should be successful using another active template from the platform

If the template from which VR is created got deleted, the state is set to inactive and removed to null. Since the template is already deleted, the VR can't be created using this template again. If someone restarts network with cleanup then it will try to deploy the vr from the old non existing template again. So search only for active template which are not yet deleted.

svenvogel · 2020-04-30T10:04:18Z

Hi @ravening small question. 🙏 how do you delete the template? api or ui?

ravening · 2020-05-01T07:29:18Z

Hi @ravening small question. 🙏 how do you delete the template? api or ui?

Hello @svenvogel , its mostly through UI but can be done through api as well I guess but I have not tried using api

yadvr · 2020-07-07T07:19:12Z

@blueorangutan package

blueorangutan · 2020-07-07T07:20:09Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-07-07T07:58:17Z

Packaging result: ✔centos7 ✔debian. JID-1542

yadvr · 2020-07-07T14:12:08Z

@blueorangutan test

blueorangutan · 2020-07-07T14:13:11Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-07-10T21:04:24Z

Trillian test result (tid-2054)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44443 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4047-t2054-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_deploy_kubernetes_ha_cluster	`Error`	3612.81	test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster	`Error`	0.04	test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster	`Error`	0.04	test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster	`Error`	0.03	test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster	`Error`	0.03	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	35.52	test_kubernetes_clusters.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	306.26	test_vpc_redundant.py

DaanHoogland · 2020-07-29T08:06:36Z

as per your description @ravening, "If the template from which VR is created got deleted, the state
is set to inactive and removed to null.", it seems the 'real' bug is that removed is set to null whilst it should be set to the time of deletion. Your code will work, but is it not hiding this 'real' problem? Being very defensive, we might want to address both issues.

ravening · 2020-07-29T09:29:12Z

as per your description @ravening, "If the template from which VR is created got deleted, the state
is set to inactive and removed to null.", it seems the 'real' bug is that removed is set to null whilst it should be set to the time of deletion. Your code will work, but is it not hiding this 'real' problem? Being very defensive, we might want to address both issues.

I will see if I can reproduce the issue to check which part of the code is setting it to null instead of removed timestamp

DaanHoogland · 2020-10-20T11:34:52Z

@nvazquez do you have an opinion as well on this?

nvazquez · 2020-11-16T11:02:37Z

I think the fix makes sense as it is now. I don't know the reason why we set the template to Inactive but not removed instead of removing it (timestamp on the removed column) as we normally do with other entities, probably it is not a bug but the expected behaviour by design

nvazquez

Code LGTM, have not tested it

DaanHoogland · 2020-11-16T11:40:03Z

ok tnx @nvazquez . As said I do have my doubt as I think we might be hiding the issue, but will not 👎 .

GabrielBrascher

Code LGTM

shwstppr · 2021-02-15T08:28:04Z

@blueorangutan package

blueorangutan · 2021-02-15T08:29:27Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-02-15T09:13:43Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2707

yadvr · 2021-02-19T08:49:55Z

@blueorangutan package

blueorangutan · 2021-02-19T08:50:45Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-02-19T09:10:26Z

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2746

yadvr · 2021-02-19T10:33:13Z

@blueorangutan package

blueorangutan · 2021-02-19T10:34:06Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-02-19T12:18:27Z

Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2760

shwstppr · 2021-02-22T10:05:50Z

@blueorangutan package

blueorangutan · 2021-02-22T10:06:58Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-02-22T11:21:08Z

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2779

blueorangutan · 2021-02-22T13:06:32Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2784

shwstppr · 2021-02-23T05:21:36Z

@blueorangutan test

blueorangutan · 2021-02-23T05:23:01Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-02-23T17:07:19Z

Trillian test result (tid-3596)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40164 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4047-t3596-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 79 look OK, 7 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	`Error`	34.14	test_primary_storage.py
test_04_deploy_and_scale_kubernetes_cluster	`Failure`	44.48	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	3612.32	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	0.08	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.07	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	112.33	test_kubernetes_clusters.py
test_01_sys_vm_start	`Failure`	0.08	test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
test_01_deploy_vm_on_specific_host	`Error`	20.99	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	4.43	test_vm_deployment_planner.py
test_11_migrate_vm	`Error`	4.39	test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	303.83	test_hostha_kvm.py

shwstppr · 2021-02-23T18:08:30Z

@blueorangutan test

blueorangutan · 2021-02-23T18:09:09Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-02-24T03:38:07Z

Trillian test result (tid-3609)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32372 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4047-t3609-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

shwstppr

lgtm

svenvogel added the type:bug label Apr 30, 2020

svenvogel added component:templates component:virtual-router labels Apr 30, 2020

yadvr added this to the 4.15.0.0 milestone Jul 4, 2020

yadvr requested review from DaanHoogland and nvazquez July 8, 2020 06:01

PaulAngus added the NEEDS-GO-NO_GO-URGENTLY label Nov 13, 2020

nvazquez approved these changes Nov 16, 2020

View reviewed changes

nvazquez mentioned this pull request Nov 16, 2020

[Investigation] Templates/ISOs are not removed but marked as Inactive #4470

Closed

DaanHoogland requested review from GabrielBrascher and yadvr and removed request for DaanHoogland November 17, 2020 19:05

GabrielBrascher approved these changes Nov 17, 2020

View reviewed changes

yadvr modified the milestones: 4.15.0.0, 4.15.1.0 Dec 8, 2020

yadvr changed the base branch from master to 4.15 February 19, 2021 08:32

yadvr closed this Feb 19, 2021

yadvr reopened this Feb 19, 2021

yadvr approved these changes Feb 23, 2021

View reviewed changes

shwstppr approved these changes Feb 24, 2021

View reviewed changes

yadvr closed this Feb 24, 2021

yadvr reopened this Feb 24, 2021

yadvr merged commit 7874918 into apache:4.15 Feb 25, 2021

Conversation

ravening commented Apr 28, 2020

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

svenvogel commented Apr 30, 2020

Uh oh!

ravening commented May 1, 2020

Uh oh!

yadvr commented Jul 7, 2020

Uh oh!

blueorangutan commented Jul 7, 2020

Uh oh!

blueorangutan commented Jul 7, 2020

Uh oh!

yadvr commented Jul 7, 2020

Uh oh!

blueorangutan commented Jul 7, 2020

Uh oh!

blueorangutan commented Jul 10, 2020

Uh oh!

DaanHoogland commented Jul 29, 2020

Uh oh!

ravening commented Jul 29, 2020

Uh oh!

DaanHoogland commented Oct 20, 2020

Uh oh!

nvazquez commented Nov 16, 2020

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Nov 16, 2020

Uh oh!

GabrielBrascher left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Feb 15, 2021

Uh oh!

blueorangutan commented Feb 15, 2021

Uh oh!

blueorangutan commented Feb 15, 2021

Uh oh!

yadvr commented Feb 19, 2021

Uh oh!

blueorangutan commented Feb 19, 2021

Uh oh!

blueorangutan commented Feb 19, 2021

Uh oh!

yadvr commented Feb 19, 2021

Uh oh!

blueorangutan commented Feb 19, 2021

Uh oh!

blueorangutan commented Feb 19, 2021

Uh oh!

shwstppr commented Feb 22, 2021

Uh oh!

blueorangutan commented Feb 22, 2021

Uh oh!

blueorangutan commented Feb 22, 2021

Uh oh!

blueorangutan commented Feb 22, 2021

Uh oh!

shwstppr commented Feb 23, 2021

Uh oh!

blueorangutan commented Feb 23, 2021

Uh oh!

blueorangutan commented Feb 23, 2021

Uh oh!

shwstppr commented Feb 23, 2021

Uh oh!

blueorangutan commented Feb 23, 2021

Uh oh!

blueorangutan commented Feb 24, 2021

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!