Skip to content

client: explicitly define SslContextFactory::Server for https#4288

Merged
yadvr merged 1 commit into
apache:4.14from
shapeblue:jetty-ssl-fix
Aug 28, 2020
Merged

client: explicitly define SslContextFactory::Server for https#4288
yadvr merged 1 commit into
apache:4.14from
shapeblue:jetty-ssl-fix

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Aug 27, 2020

Fixes #4199

Latest jetty used in 4.14/master has deprecated new SslContextFactory(); and requires use of Client|Server. This fixes that.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Fixes apache#4199

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.14.1.0 milestone Aug 27, 2020
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Aug 27, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Aug 27, 2020

This fixes the ssl cert issue for master which uses latest jetty which has deprecated use of the old SSL context factory.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1829

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Aug 27, 2020

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-2581)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52968 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4288-t2581-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spaceman1984
Copy link
Copy Markdown
Contributor

Code LGTM, did not test.

@yadvr yadvr merged commit 0501575 into apache:4.14 Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants