Skip to content

hostresponse: Setting memory allocated to percentage #4477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidjumani wants to merge 1 commit into from
Closed

hostresponse: Setting memory allocated to percentage #4477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/src/main/java/org/apache/cloudstack/api/response/HostResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ public class HostResponse extends BaseResponse {

@SerializedName("memoryallocated")
@Param(description = "the amount of the host's memory currently allocated")
private long memoryAllocated;
private String memoryAllocated;

@SerializedName("memoryused")
@Param(description = "the amount of the host's memory currently used")
Expand Down Expand Up @@ -353,7 +353,7 @@ public void setMemWithOverprovisioning(String memWithOverprovisioning){
this.memWithOverprovisioning=memWithOverprovisioning;
}

public void setMemoryAllocated(long memoryAllocated) {
public void setMemoryAllocated(String memoryAllocated) {
this.memoryAllocated = memoryAllocated;
}

Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public HostResponse newHostResponse(HostJoinVO host, EnumSet<HostDetails> detail
hostResponse.setMemoryTotal(host.getTotalMemory());
Float totalMemorywithOverprovisioning = host.getTotalMemory() * ApiDBUtils.getMemOverprovisioningFactor(host.getClusterId());
hostResponse.setMemWithOverprovisioning(totalMemorywithOverprovisioning.toString());
hostResponse.setMemoryAllocated(mem);
hostResponse.setMemoryAllocated(decimalFormat.format((float) mem / totalMemorywithOverprovisioning * 100.0f) +"%");

String hostTags = host.getTag();
hostResponse.setHostTags(host.getTag());
Expand Down