ui: fix add management ip range form#5427
Merged
Merged
Conversation
Contributor
Author
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
yadvr
approved these changes
Sep 10, 2021
Add management IP range form shows same pod multiple times when the pods has multiple IP ranges. This PR fixes the behaviour. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr
force-pushed
the
fix-ui-addmanagementiprange
branch
from
0957eab to
56092fd
Compare
Member
1 similar comment
Contributor
Author
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
yadvr
approved these changes
Sep 10, 2021
weizhouapache
approved these changes
Sep 10, 2021
Member
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
this seems to be a blocker issue
|
UI build: ✔️ |
nvazquez
approved these changes
Sep 10, 2021
Member
|
Tested LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add management IP range form shows the same pod multiple times when the pod has multiple IP ranges.
This PR fixes the behaviour.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?