resource limit: Fix resource limit check on VM start by Pearl1594 · Pull Request #5428 · apache/cloudstack

Pearl1594 · 2021-09-09T09:56:51Z

Description

This PR addresses #4155 - wherein resource limits for an account aren't checked when a VM's settings i.e., cpuNumber / memory are updated i.e., VM deployed with custom constrained compute offering.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Set resource limit to a low value for domain admin:

Deployed a VM using custom constrained compute offering with cpuNumber = 1 and memory = 100MB

Updated VM settings with cpuNumber = 4 (max = 2) - Failed as expected:

Updated VM settings with memory = 1200 (max = 1000) - Failed as expected:

When VM settings for cpuNumber / memory is updated to a value exceeding the limit of the custom service offering used - Fails - check added to verify limits during vm update:

Pearl1594 · 2021-09-09T10:17:31Z

@blueorangutan package

blueorangutan · 2021-09-09T10:18:02Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-09T10:42:46Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1195

Pearl1594 · 2021-09-09T10:51:50Z

@blueorangutan test

blueorangutan · 2021-09-09T10:53:02Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-09-09T20:42:14Z

Trillian test result (tid-1999)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33673 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5428-t1999-kvm-centos7.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_snapshots_with_removed_data_store	`Error`	51.24	test_snapshots.py

…limit-checks

Pearl1594 · 2021-09-13T09:15:01Z

@blueorangutan package

blueorangutan · 2021-09-13T09:17:02Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-13T10:40:56Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 1213

Pearl1594 · 2021-09-13T12:36:12Z

@blueorangutan package

blueorangutan · 2021-09-13T12:37:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-13T12:45:33Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 1216

weizhouapache · 2021-09-13T12:46:14Z

@Pearl1594
fyi, there is a component test test/integration/component/test_resource_count_running_vms.py
you can update the test if you like.

Pearl1594 · 2021-09-13T12:52:17Z

Thanks for the review @weizhouapache I'll address your comments and have a look at the component test.

…limit-checks

Pearl1594 · 2021-09-21T04:40:34Z

@blueorangutan package

blueorangutan · 2021-09-21T04:41:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-21T05:11:38Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1336

sureshanaparti · 2021-09-21T05:44:35Z

@blueorangutan test

blueorangutan · 2021-09-21T05:45:02Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2021-09-21T09:16:06Z

@Pearl1594 the resource limit test in travis job 15 failed. I restarted it, can you keep an eye on it?

Pearl1594 · 2021-09-21T09:19:34Z

Sure @DaanHoogland - will keep an eye on it - seems like the following set of tests from that job are failing across other PRs too

+--------------------------------------+---------+-------+----------------+

|                 Test                 | Result  | Time  |   Test file    |

+======================================+=========+=======+================+

| test_02_list_publicip_domain_admin   | Failure | 0.146 | test_public_ip |

+--------------------------------------+---------+-------+----------------+

| test_03_list_publicip_user_domain    | Failure | 0.404 | test_public_ip |

+--------------------------------------+---------+-------+----------------+

| test_04_list_publicip_all_subdomains | Failure | 0.397 | test_public_ip |

+--------------------------------------+---------+-------+----------------+

| test_05_list_publicip_user_domain    | Failure | 2.632 | test_public_ip |

+--------------------------------------+---------+-------+----------------+

weizhouapache · 2021-09-21T09:34:23Z

Sure @DaanHoogland - will keep an eye on it - seems like the following set of tests from that job are failing across other PRs too

+--------------------------------------+---------+-------+----------------+

|                 Test                 | Result  | Time  |   Test file    |

+======================================+=========+=======+================+

| test_02_list_publicip_domain_admin   | Failure | 0.146 | test_public_ip |

+--------------------------------------+---------+-------+----------------+

| test_03_list_publicip_user_domain    | Failure | 0.404 | test_public_ip |

+--------------------------------------+---------+-------+----------------+

| test_04_list_publicip_all_subdomains | Failure | 0.397 | test_public_ip |

+--------------------------------------+---------+-------+----------------+

| test_05_list_publicip_user_domain    | Failure | 2.632 | test_public_ip |

+--------------------------------------+---------+-------+----------------+

@Pearl1594
this seems to be caused by #5464 . I will look into it.

Pearl1594 · 2021-09-21T09:36:04Z

Alright @DaanHoogland Thanks!

weizhouapache · 2021-09-21T11:13:46Z

@Pearl1594
I have created #5486 to fix the issue. let's see if travis passes.

Pearl1594 · 2021-09-21T11:16:20Z

@Pearl1594
I have created #5486 to fix the issue. let's see if travis passes.
Thanks @weizhouapache!

blueorangutan · 2021-09-21T16:09:35Z

Trillian test result (tid-2139)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36154 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5428-t2139-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Pearl1594 · 2021-09-23T05:57:12Z

@blueorangutan package

blueorangutan · 2021-09-23T05:59:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-23T06:29:42Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1369

Pearl1594 · 2021-09-23T06:39:34Z

@blueorangutan test

blueorangutan · 2021-09-23T06:40:03Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-09-23T07:18:27Z

Trillian Build Failed (tid-2176)

sureshanaparti · 2021-09-23T08:00:18Z

@blueorangutan test

blueorangutan · 2021-09-23T08:04:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-09-23T19:35:20Z

Trillian test result (tid-2178)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40219 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5428-t2178-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

resource limit: Fix resource limit check on VM start

b301e14

Pearl1594 requested review from shwstppr and weizhouapache September 9, 2021 09:56

Pearl1594 added this to the 4.16.0.0 milestone Sep 9, 2021

Pearl1594 requested a review from nvazquez September 9, 2021 09:57

shwstppr reviewed Sep 9, 2021

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

refactor

729f14b

weizhouapache reviewed Sep 9, 2021

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

Pearl1594 added 2 commits September 13, 2021 14:12

Merge branch 'main' of https://github.com/apache/cloudstack into fix-…

c45ce0e

…limit-checks

refactor logic

768d5d9

Pearl1594 requested review from shwstppr and weizhouapache September 13, 2021 09:14

weizhouapache reviewed Sep 13, 2021

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

weizhouapache reviewed Sep 13, 2021

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

address comments

9a0ebda

weizhouapache reviewed Sep 13, 2021

View reviewed changes

Merge branch 'main' of https://github.com/apache/cloudstack into fix-…

681a4eb

…limit-checks

nvazquez closed this Sep 23, 2021

nvazquez reopened this Sep 23, 2021

weizhouapache reviewed Sep 23, 2021

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

move check

e9e3dc8

weizhouapache approved these changes Sep 23, 2021

View reviewed changes

nvazquez removed the status:needs-testing label Sep 23, 2021

sureshanaparti merged commit 74bb806 into apache:main Sep 24, 2021

yadvr mentioned this pull request Sep 27, 2021

Domain Limit Exploit for Unlimited Domain Ressources #4155

Closed

Conversation

Pearl1594 commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Pearl1594 commented Sep 9, 2021

Uh oh!

blueorangutan commented Sep 9, 2021

Uh oh!

blueorangutan commented Sep 9, 2021

Uh oh!

Pearl1594 commented Sep 9, 2021

Uh oh!

blueorangutan commented Sep 9, 2021

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented Sep 9, 2021

Uh oh!

Pearl1594 commented Sep 13, 2021

Uh oh!

blueorangutan commented Sep 13, 2021

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented Sep 13, 2021

Uh oh!

Pearl1594 commented Sep 13, 2021

Uh oh!

blueorangutan commented Sep 13, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented Sep 13, 2021

Uh oh!

weizhouapache commented Sep 13, 2021

Uh oh!

Pearl1594 commented Sep 13, 2021

Uh oh!

Pearl1594 commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

sureshanaparti commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

DaanHoogland commented Sep 21, 2021

Uh oh!

Pearl1594 commented Sep 21, 2021

Uh oh!

weizhouapache commented Sep 21, 2021

Uh oh!

Pearl1594 commented Sep 21, 2021

Uh oh!

weizhouapache commented Sep 21, 2021

Uh oh!

Pearl1594 commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

Uh oh!

Pearl1594 commented Sep 23, 2021

Uh oh!

blueorangutan commented Sep 23, 2021

Uh oh!

blueorangutan commented Sep 23, 2021

Uh oh!

Pearl1594 commented Sep 23, 2021

Uh oh!

Pearl1594 commented Sep 9, 2021 •

edited

Loading