api, ui: return default ui pagesize as part of capability response#5432
Merged
Conversation
listConfigurations is not available for all roles and therefore not fit to use in UI for a generic functionality. This PR makes default ui pagesize a part for listCapabilities API response to make it available for UI across different role accounts. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Contributor
Author
|
@blueorangutan package @rhtyd this is a bit elaborate fix for UI login, pagesize issue. #5430 is a short one. |
|
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
yadvr
approved these changes
Sep 10, 2021
Member
|
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Member
|
Tested lgtm |
Member
|
code lgtm |
weizhouapache
approved these changes
Sep 10, 2021
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 1199 |
Member
|
Manually tested; upgraded 4.15.2 RC1 to this PR using pkgs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
listConfigurations is not available for all roles and therefore not fit to use in UI for a generic functionality.
This PR makes default ui pagesize a part for listCapabilities API response to make it available for UI across different role accounts.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?