ui: add custom form for update template by shwstppr · Pull Request #5434 · apache/cloudstack

shwstppr · 2021-09-10T13:36:43Z

Description

Adds a custom UI form for updating a template with more options such as details.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

sureshanaparti · 2022-01-17T06:03:37Z

@blueorangutan ui

blueorangutan · 2022-01-17T06:04:03Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-01-17T06:28:37Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5434 (SL-JID-1024)

sureshanaparti · 2022-01-20T08:44:48Z

Hi @shwstppr can you address the outstanding comments please. thanks.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2022-01-20T10:43:40Z

@blueorangutan ui

blueorangutan · 2022-01-20T10:44:06Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-01-20T10:52:34Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5434 (SL-JID-1044)

utchoang

LGTM!

sureshanaparti · 2022-01-21T12:56:28Z

@shwstppr Checked with KVM & VMware templates. I could see the keyboard type in the update template API call from UI, but it seems the API call is not including keyboard in details parameter (and so if any keyboard detail exists, it gets deleted). Please check.

sureshanaparti · 2022-01-21T13:29:44Z

+        const params = {
+          id: this.resource.id
+        }
+        const detailsField = ['rootDiskController', 'nicAdapter', 'keyboardType']


Suggested change

const detailsField = ['rootDiskController', 'nicAdapter', 'keyboardType']

const detailsField = ['rootDiskController', 'nicAdapter', 'keyboard']

May be, this is the issue with keyboard detail.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2022-01-24T06:57:34Z

@sureshanaparti fixed the empty nicAdapter, keyboard behaviour. If no value is selected for these fields, detail will not be passed to the API and it will be removed for the template.
Added warning for changing template type to SYSTEM

shwstppr · 2022-01-24T06:59:13Z

@blueorangutan ui

blueorangutan · 2022-01-24T07:00:04Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-01-24T07:05:34Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5434 (SL-JID-1054)

sureshanaparti · 2022-01-24T07:42:59Z

@sureshanaparti fixed the empty nicAdapter, keyboard behaviour. If no value is selected for these fields, detail will not be passed to the API and it will be removed for the template.
Added warning for changing template type to SYSTEM

ok @shwstppr , will check. thanks.

sureshanaparti

LGTM

Pearl1594 · 2022-01-24T12:40:26Z

@shwstppr I believe we need to disable / remove the templatetype field from the form when a user with User role logs in -

shwstppr · 2022-01-24T15:54:58Z

@blueorangutan ui

blueorangutan · 2022-01-24T15:56:03Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-01-24T16:01:53Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5434 (SL-JID-1057)

shwstppr · 2022-01-24T16:05:24Z

@Pearl1594 can you please try again

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2022-01-25T03:56:39Z

@blueorangutan ui

blueorangutan · 2022-01-25T03:58:03Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-01-25T04:07:44Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5434 (SL-JID-1061)

Pearl1594

Tested as root admin and user - works as expected. LGTM

shwstppr added 3 commits September 10, 2021 19:04

ui: add custom form for update template

b125cab

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Merge branch 'main' into add-ui-updatetemplateform

de238a8

fix

b15037c

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr changed the base branch from main to 4.16 November 15, 2021 10:09

yadvr added this to the 4.16.1.0 milestone Nov 25, 2021

weizhouapache added the component:UI label Jan 10, 2022

sureshanaparti assigned shwstppr Jan 13, 2022

sureshanaparti requested a review from utchoang January 13, 2022 12:45

shwstppr marked this pull request as ready for review January 17, 2022 06:09

utchoang reviewed Jan 17, 2022

View reviewed changes

Comment thread ui/src/views/image/UpdateTemplate.vue

shwstppr added 2 commits January 20, 2022 16:11

label fix

4c8ed77

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Merge branch '4.16' into add-ui-updatetemplateform

e575435

sureshanaparti requested review from Pearl1594 and utchoang January 20, 2022 12:11

utchoang approved these changes Jan 21, 2022

View reviewed changes

sureshanaparti reviewed Jan 21, 2022

View reviewed changes

changes and fix

6b5092a

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

sureshanaparti approved these changes Jan 24, 2022

View reviewed changes

fix

4ca5dc4

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr force-pushed the add-ui-updatetemplateform branch from 640cf74 to 4ca5dc4 Compare January 25, 2022 03:56

Pearl1594 approved these changes Jan 25, 2022

View reviewed changes

sureshanaparti merged commit d18ef1c into apache:4.16 Jan 25, 2022

	const detailsField = ['rootDiskController', 'nicAdapter', 'keyboardType']
	const detailsField = ['rootDiskController', 'nicAdapter', 'keyboard']

Conversation

shwstppr commented Sep 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

sureshanaparti commented Jan 17, 2022

Uh oh!

blueorangutan commented Jan 17, 2022

Uh oh!

blueorangutan commented Jan 17, 2022

Uh oh!

Uh oh!

sureshanaparti commented Jan 20, 2022

Uh oh!

shwstppr commented Jan 20, 2022

Uh oh!

blueorangutan commented Jan 20, 2022

Uh oh!

blueorangutan commented Jan 20, 2022

Uh oh!

utchoang left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jan 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sureshanaparti Jan 21, 2022

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Jan 24, 2022

Uh oh!

shwstppr commented Jan 24, 2022

Uh oh!

blueorangutan commented Jan 24, 2022

Uh oh!

blueorangutan commented Jan 24, 2022

Uh oh!

sureshanaparti commented Jan 24, 2022

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

Pearl1594 commented Jan 24, 2022

Uh oh!

shwstppr commented Jan 24, 2022

Uh oh!

blueorangutan commented Jan 24, 2022

Uh oh!

blueorangutan commented Jan 24, 2022

Uh oh!

shwstppr commented Jan 24, 2022

Uh oh!

shwstppr commented Jan 25, 2022

Uh oh!

blueorangutan commented Jan 25, 2022

Uh oh!

blueorangutan commented Jan 25, 2022

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shwstppr commented Sep 10, 2021 •

edited

Loading

sureshanaparti commented Jan 21, 2022 •

edited

Loading