Skip to content

[UI] Change permission to access console proxy button#5625

Merged
yadvr merged 1 commit into
apache:mainfrom
scclouds:ui-fix-console-api-permission
Dec 30, 2021
Merged

[UI] Change permission to access console proxy button#5625
yadvr merged 1 commit into
apache:mainfrom
scclouds:ui-fix-console-api-permission

Conversation

@SadiJr
Copy link
Copy Markdown
Contributor

@SadiJr SadiJr commented Oct 25, 2021

Description

This PR fixes #5623.

Also, some more information that is not present in the issue in question:

  • Although the proxy console access button does not appear in the UI, users with access permission to the VM in question have access to the console as well. Simply generate the console access link using another user, copy that link, and, on the user without access to the console button, type that link.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

Its tested in a local lab, trying to reproduce the steps of the issue #5623.

@utchoang
Copy link
Copy Markdown

utchoang commented Nov 1, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5625 (SL-JID-798)

@sureshanaparti
Copy link
Copy Markdown
Contributor

Hi @SadiJr Is this PR good to go in 4.16.1 ?

@SadiJr
Copy link
Copy Markdown
Contributor Author

SadiJr commented Dec 16, 2021

@sureshanaparti I guess yes, but for me, it is fine to go into main only.

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti I guess yes, but for me, it is fine to go into main only.

ok, thanks for confirming @SadiJr

@yadvr yadvr merged commit d0721c5 into apache:main Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console Access requires updateVirtualMachine API privileges

8 participants