ipv6: disable IPv6-only shared network with VR by weizhouapache · Pull Request #5810 · apache/cloudstack

weizhouapache · 2021-12-24T11:14:56Z

Description

This PR fixes #5640 by disabling IPv6-only Shared network with VR provider.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2021-12-24T11:15:26Z

@blueorangutan package

blueorangutan · 2021-12-24T11:17:03Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-12-24T11:27:31Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 2013

weizhouapache · 2021-12-24T12:30:42Z

@blueorangutan package

blueorangutan · 2021-12-24T12:31:03Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-12-24T12:40:09Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 2014

weizhouapache · 2021-12-24T12:53:00Z

@blueorangutan package

yadvr · 2021-12-28T05:58:15Z

@blueorangutan package

blueorangutan · 2021-12-28T05:59:04Z

@rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-12-28T07:57:43Z

Packaging result: ✖️ el7 ✖️ el8 ✔️ debian ✖️ suse15. SL-JID 2029

sureshanaparti · 2021-12-28T18:59:06Z

@blueorangutan package

blueorangutan · 2021-12-28T19:00:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-12-28T19:54:51Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2034

sureshanaparti · 2021-12-29T06:40:46Z

@blueorangutan test

blueorangutan · 2021-12-29T06:41:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-12-29T17:37:11Z

Trillian test result (tid-2751)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37871 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5810-t2751-kvm-centos7.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_05_ping_in_cpvm_success	`Failure`	14.37	test_diagnostics.py

weizhouapache · 2022-01-06T08:06:39Z

@blueorangutan package

blueorangutan · 2022-01-06T08:07:03Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-06T09:56:16Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2108

weizhouapache · 2022-01-06T10:28:23Z

@blueorangutan test

blueorangutan · 2022-01-06T10:29:07Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

weizhouapache · 2022-01-06T13:06:25Z

@blueorangutan package

blueorangutan · 2022-01-06T13:07:03Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-06T14:33:16Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2121

weizhouapache · 2022-01-06T14:38:52Z

@blueorangutan test

blueorangutan · 2022-01-06T14:40:03Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

GabrielBrascher

Code LGTM

Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>

…e/orchestration/NetworkOrchestrator.java Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>

weizhouapache · 2022-01-06T18:26:52Z

@blueorangutan package

blueorangutan · 2022-01-06T18:28:03Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-06T20:03:27Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2125

blueorangutan · 2022-01-06T20:45:13Z

Trillian test result (tid-2806)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35292 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5810-t2806-kvm-centos7.zip
Smoke tests completed. 87 look OK, 5 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	`Error`	0.65	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.13	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.24	test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	35.01	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	80.28	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	41.11	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.05	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	77.19	test_kubernetes_clusters.py
test_01_secure_vm_migration	`Error`	162.65	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	272.46	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	148.04	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	45.92	test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store	`Error`	9.49	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	9.49	test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	302.88	test_hostha_kvm.py

weizhouapache · 2022-01-07T10:18:20Z

@blueorangutan test

blueorangutan · 2022-01-07T10:19:03Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

GutoVeronezi

CLGTM

blueorangutan · 2022-01-07T22:44:38Z

Trillian test result (tid-2822)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43297 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5810-t2822-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

yadvr

LGTM, needs testing (if done/satisfied, pl merge)

sureshanaparti · 2022-01-10T14:03:44Z

@blueorangutan package

blueorangutan · 2022-01-10T14:04:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-10T15:24:01Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2165

sureshanaparti

Verified the changes. LGTM

weizhouapache · 2022-01-12T08:06:09Z

Verified the changes. LGTM

Great, thanks for testing

ipv6: disable IPv6-only shared network with VR

87fc02e

Update apache#5810: import org.apache.commons.lang3.StringUtils

91e296e

weizhouapache changed the base branch from 4.16 to main December 24, 2021 12:52

weizhouapache closed this Dec 24, 2021

weizhouapache reopened this Dec 24, 2021

sureshanaparti added this to the 4.16.1.0 milestone Jan 6, 2022

sureshanaparti assigned weizhouapache Jan 6, 2022

sureshanaparti requested review from GabrielBrascher and GutoVeronezi January 6, 2022 12:28

weizhouapache reopened this Jan 6, 2022

weizhouapache marked this pull request as ready for review January 6, 2022 14:39

GabrielBrascher approved these changes Jan 6, 2022

View reviewed changes

GutoVeronezi reviewed Jan 6, 2022

View reviewed changes

Comment thread server/src/main/java/com/cloud/network/NetworkServiceImpl.java

Comment thread server/src/main/java/com/cloud/network/NetworkServiceImpl.java Outdated

Comment thread ...hestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java Outdated

weizhouapache and others added 2 commits January 6, 2022 19:26

Update server/src/main/java/com/cloud/network/NetworkServiceImpl.java

4c31448

Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>

Update engine/orchestration/src/main/java/org/apache/cloudstack/engin…

6578445

…e/orchestration/NetworkOrchestrator.java Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>

GutoVeronezi approved these changes Jan 7, 2022

View reviewed changes

yadvr approved these changes Jan 8, 2022

View reviewed changes

sureshanaparti assigned sureshanaparti and unassigned weizhouapache Jan 10, 2022

sureshanaparti approved these changes Jan 12, 2022

View reviewed changes

sureshanaparti merged commit 216bea1 into apache:4.16 Jan 12, 2022

sureshanaparti mentioned this pull request Jan 12, 2022

NPE while deploy vm on a IPv6-only shared network #5640

Closed

weizhouapache deleted the 4.16-disable-ipv6-only-shared-network branch December 9, 2022 08:28

Conversation

weizhouapache commented Dec 24, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Dec 24, 2021

Uh oh!

blueorangutan commented Dec 24, 2021

Uh oh!

blueorangutan commented Dec 24, 2021

Uh oh!

weizhouapache commented Dec 24, 2021

Uh oh!

blueorangutan commented Dec 24, 2021

Uh oh!

blueorangutan commented Dec 24, 2021

Uh oh!

weizhouapache commented Dec 24, 2021

Uh oh!

yadvr commented Dec 28, 2021

Uh oh!

blueorangutan commented Dec 28, 2021

Uh oh!

blueorangutan commented Dec 28, 2021

Uh oh!

sureshanaparti commented Dec 28, 2021

Uh oh!

blueorangutan commented Dec 28, 2021

Uh oh!

blueorangutan commented Dec 28, 2021

Uh oh!

sureshanaparti commented Dec 29, 2021

Uh oh!

blueorangutan commented Dec 29, 2021

Uh oh!

blueorangutan commented Dec 29, 2021

Uh oh!

weizhouapache commented Jan 6, 2022

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

weizhouapache commented Jan 6, 2022

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

weizhouapache commented Jan 6, 2022

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

weizhouapache commented Jan 6, 2022

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

GabrielBrascher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weizhouapache commented Jan 6, 2022

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

weizhouapache commented Jan 7, 2022

Uh oh!

blueorangutan commented Jan 7, 2022

Uh oh!