Skip to content

Update proper destroy status when SSVM is destroyed.#5908

Merged
sureshanaparti merged 1 commit into
apache:4.16from
shapeblue:destroy-ssvm-status
Feb 2, 2022
Merged

Update proper destroy status when SSVM is destroyed.#5908
sureshanaparti merged 1 commit into
apache:4.16from
shapeblue:destroy-ssvm-status

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

Description

This PR fixes reporting of the destroy status when SSVM is destroyed.

Issue due to changes here:

1aef5cb#diff-d8fdd320d08cc4eff5dfe391d01c910c660e08ced5afcb2915c78da35f23c453R988-R996

Fixes #5895

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@sureshanaparti sureshanaparti changed the base branch from main to 4.16 January 28, 2022 09:42
@sureshanaparti sureshanaparti added this to the 4.16.1.0 milestone Jan 28, 2022
@sureshanaparti sureshanaparti self-assigned this Jan 28, 2022
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
make sense

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm. So we basically failed to delete what was no longer there in the first place? strange.

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

clgtm. So we basically failed to delete what was no longer there in the first place? strange.

that is addressed as the fix there, but it should also return true when host entry doesn't exists.

@DaanHoogland
Copy link
Copy Markdown
Contributor

clgtm. So we basically failed to delete what was no longer there in the first place? strange.

that is addressed as the fix there, but it should also return true when host entry doesn't exists.

yes, of course. fix is good afaics

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2366

@DaanHoogland DaanHoogland self-assigned this Jan 31, 2022
@apache apache deleted a comment from blueorangutan Jan 31, 2022
@DaanHoogland
Copy link
Copy Markdown
Contributor

works as expected :
image

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@apache apache deleted a comment from sureshanaparti Feb 1, 2022
@apache apache deleted a comment from blueorangutan Feb 1, 2022
@apache apache deleted a comment from blueorangutan Feb 1, 2022
@apache apache deleted a comment from blueorangutan Feb 1, 2022
@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-3106)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32599 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5908-t3106-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@apache apache deleted a comment from blueorangutan Feb 2, 2022
@apache apache deleted a comment from blueorangutan Feb 2, 2022
@sureshanaparti sureshanaparti merged commit 1b3e7f6 into apache:4.16 Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Destroying SSVM reported to have failed, while it actually succeeded

6 participants