Skip to content

ui, Adv zone + SG: Fix invocation of create/revoke APIs for ingress/egress security group rules#6170

Merged
nvazquez merged 1 commit into
apache:mainfrom
shapeblue:fix-adv-zone-sg-rules
Mar 28, 2022
Merged

ui, Adv zone + SG: Fix invocation of create/revoke APIs for ingress/egress security group rules#6170
nvazquez merged 1 commit into
apache:mainfrom
shapeblue:fix-adv-zone-sg-rules

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

Description

This PR fixes the incorrect invocation of API for creation and revocation of ingress / egress security group rules - which is done based on the tab.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@Pearl1594
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6170 (SL-JID-1306)

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@nvazquez nvazquez merged commit 6d11e2f into apache:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants