Skip to content

[KVM] Ensure configdrive path is edited properly during live migration#6173

Merged
weizhouapache merged 1 commit into
apache:4.16from
shapeblue:configdrivelivemigr
Mar 29, 2022
Merged

[KVM] Ensure configdrive path is edited properly during live migration#6173
weizhouapache merged 1 commit into
apache:4.16from
shapeblue:configdrivelivemigr

Conversation

@nvazquez
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez commented Mar 28, 2022

Description

This PR fixes live migration under the following configuration:

  • Single management server, two CentOS 7 KVM hypervisors.
  • Using SharedMountPoint (NFS) for root volume primary storage
  • Set up network with configdrive as a user data provider
  • vm.configdrive.force.host.cache.use = true

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@nvazquez nvazquez added this to the 4.17.0.0 milestone Mar 28, 2022
@nvazquez
Copy link
Copy Markdown
Contributor Author

nvazquez commented Mar 28, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 28, 2022

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 28, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2999

@nvazquez nvazquez force-pushed the configdrivelivemigr branch from 021bd85 to 4a5b18c Compare March 28, 2022 14:56
@nvazquez
Copy link
Copy Markdown
Contributor Author

nvazquez commented Mar 28, 2022

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 28, 2022

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 29, 2022

Trillian test result (tid-3739)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33345 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6173-t3739-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

weizhouapache
weizhouapache approved these changes Mar 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok.

found an issue, which is not caused by this PR: migration fails if hosts have different host cache locations. for example,
in agent.properties of host1: host.cache.location=/var/cache/cloud
in agent.properties of host2: host.cache.location=/var/cache/cloud2

Pearl1594
Pearl1594 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified fix. LGTM

@weizhouapache weizhouapache merged commit a69ab3b into apache:4.16 Mar 29, 2022
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request May 17, 2022
@nvazquez
Ensure configdrive path is edited properly during live migration (apa…
dfc1f26 
…che#6173) (apache#138)
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@nvazquez @yadvr
Ensure configdrive path is edited properly during live migration (apa…
0b43bbd 
…che#6173)

(cherry picked from commit a69ab3b)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@nvazquez @yadvr
Ensure configdrive path is edited properly during live migration (apa…
84cf820 
…che#6173)

(cherry picked from commit a69ab3b)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@nvazquez @yadvr
Ensure configdrive path is edited properly during live migration (apa…
053d91a 
…che#6173)

(cherry picked from commit a69ab3b)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti

Assignees

No one assigned

Labels

component:kvm component:migration type:bug

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nvazquez @blueorangutan @Pearl1594 @weizhouapache