Skip to content

ui: Fix project theme on reload or refresh#7893

Merged
weizhouapache merged 2 commits into
apache:4.18from
shapeblue:project-theme-fix
Aug 22, 2023
Merged

ui: Fix project theme on reload or refresh#7893
weizhouapache merged 2 commits into
apache:4.18from
shapeblue:project-theme-fix

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Aug 22, 2023

On UI refresh or opening in new tab, if project is selected also toggle the theme to match dark/light as per project vs default view. Also picks css fixes from main branch.

Fixes ##7736

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

yadvr added 2 commits August 22, 2023 15:15
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.18.1.0 milestone Aug 22, 2023
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Aug 22, 2023

How I tested this:

  • In old 4.18, create a project and select it; now refresh the UI -> the nav bar goes light (from dark)
  • With this fix, create a project and select it; now refresh the UI -> the nav bar goes dark per the select project ID (if it's default view, it stays light theme)

@yadvr yadvr changed the title Project theme fix Fix project theme on reload or refresh Aug 22, 2023
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Aug 22, 2023

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@yadvr yadvr changed the title Fix project theme on reload or refresh ui: Fix project theme on reload or refresh Aug 22, 2023
@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7893 (QA-JID-157)

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified ok

@weizhouapache weizhouapache linked an issue Aug 22, 2023 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 22, 2023

Codecov Report

Merging #7893 (b1b7097) into 4.18 (db0e7a6) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #7893      +/-   ##
============================================
- Coverage     13.06%   13.06%   -0.01%     
+ Complexity     9084     9083       -1     
============================================
  Files          2720     2720              
  Lines        257289   257289              
  Branches      40116    40116              
============================================
- Hits          33612    33610       -2     
- Misses       219455   219458       +3     
+ Partials       4222     4221       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested on QA

@weizhouapache weizhouapache merged commit 0e9a19f into apache:4.18 Aug 22, 2023
@yadvr yadvr deleted the project-theme-fix branch August 22, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI forgets project context on refresh

4 participants