ui: Fix project theme on reload or refresh#7893
Merged
Merged
Conversation
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
Author
|
How I tested this:
|
Member
Author
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Codecov Report
@@ Coverage Diff @@
## 4.18 #7893 +/- ##
============================================
- Coverage 13.06% 13.06% -0.01%
+ Complexity 9084 9083 -1
============================================
Files 2720 2720
Lines 257289 257289
Branches 40116 40116
============================================
- Hits 33612 33610 -2
- Misses 219455 219458 +3
+ Partials 4222 4221 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shwstppr
approved these changes
Aug 22, 2023
Contributor
shwstppr
left a comment
There was a problem hiding this comment.
Code LGTM. Tested on QA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On UI refresh or opening in new tab, if project is selected also toggle the theme to match dark/light as per project vs default view. Also picks css fixes from main branch.
Fixes ##7736
Types of changes