UI: Add central project store and watch functionality#7900
Merged
Conversation
Added a new getter 'allProjects' and mutation 'RELOAD_ALL_PROJECTS' to centralize the tracking of available projects in the state. This eliminates direct manipulation of the Project list in separate components and improves data consistency across the application. A watcher in ProjectMenu.vue has been implemented to handle changes to the 'allProjects' getter. The 'RELOAD_ALL_PROJECTS' mutation was also added where necessary to ensure projects list is updated in the state whenever changes occur.
Member
|
@blueorangutan ui |
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Codecov Report
@@ Coverage Diff @@
## 4.18 #7900 +/- ##
=========================================
Coverage 13.06% 13.06%
Complexity 9084 9084
=========================================
Files 2720 2720
Lines 257370 257370
Branches 40124 40124
=========================================
Hits 33614 33614
Misses 219534 219534
Partials 4222 4222 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
weizhouapache
approved these changes
Aug 24, 2023
Member
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
verified ok.
if there are many projects, it might lead to some delay
weizhouapache
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue: #7181
Added a new getter 'allProjects' and mutation 'RELOAD_ALL_PROJECTS' to centralize the tracking of available projects in the state.
This eliminates direct manipulation of the Project list in separate components and improves data consistency across the application.
A watcher in ProjectMenu.vue has been implemented to handle changes to the 'allProjects' getter.
The 'RELOAD_ALL_PROJECTS' mutation was also added where necessary to ensure the projects list is updated in the state whenever changes occur.
Types of changes
Bug Severity
How Has This Been Tested?
Before fix:
Screen.Recording.2023-08-23.at.14.00.05.mov
After Fix:
Screen.Recording.2023-08-23.at.13.41.22.mov
https://youtu.be/Ba63mpnie28