Skip to content

[COLLECTIONS-888] PatriciaTrie incompatible with Java 21 (JEP 431 Sequenced Collections) #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 1 commit into from
Apr 1, 2026
+13 −6
Merged

[COLLECTIONS-888] PatriciaTrie incompatible with Java 21 (JEP 431 Sequenced Collections) #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/main/java/org/apache/commons/collections4/trie/AbstractPatriciaTrie.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1432,10 +1432,13 @@ public Set<Map.Entry<K, V>> entrySet() {
/**
* Returns the first entry the {@link org.apache.commons.collections4.Trie} is storing.
* <p>
* This is implemented by going always to the left until
* we encounter a valid uplink. That uplink is the first key.
* This is implemented by going always to the left until we encounter a valid uplink. That uplink is the first key.
* </p>
*
* @return the first entry the {@link org.apache.commons.collections4.Trie} is storing.
* @since 4.6.0
*/
TrieEntry<K, V> firstEntry() {
public TrieEntry<K, V> firstEntry() {
// if Trie is empty, no first node.
if (isEmpty()) {
return null;
Expand Down Expand Up @@ -1715,10 +1718,14 @@ public Set<K> keySet() {
/**
* Returns the last entry the {@link org.apache.commons.collections4.Trie} is storing.
*
* <p>This is implemented by going always to the right until
* we encounter a valid uplink. That uplink is the last key.
* <p>
* This is implemented by going always to the right until we encounter a valid uplink. That uplink is the last key.
* </p>
*
* @return the last entry the {@link org.apache.commons.collections4.Trie} is storing.
* @since 4.6.0
*/
TrieEntry<K, V> lastEntry() {
public TrieEntry<K, V> lastEntry() {
return followRight(root.left);
}

Expand Down
Loading