[COLLECTIONS_886] [javadoc] CompositeSet.addComposited(Set) does not throw NullPointerException when null is passed#675
Merged
garydgregory merged 1 commit intoapache:masterfrom Mar 28, 2026
Conversation
Partha-SUST16
changed the title
garydgregory
changed the title
Member
|
Good catch! Thank you for the pull request :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Javadoc for
CompositeSet.addComposited(Set)explicitly stated that aNullPointerExceptionshould be thrown when thesetparameter isnull. However, the current implementation contains a null guard ( if set != null ) that silently ignores null input and doesn't throw an exception which was reported in COLLECTIONS_886This PR removed the NPE condition from the method as it already had test code
org.apache.commons.collections4.set.CompositeSetTest.testAddCompositedwhich adds null to the CompositeSet using this method.