Conversation
timsaucer
reviewed
Dec 10, 2024
Member
timsaucer
left a comment
There was a problem hiding this comment.
Thank you for the additions. Do you think this is needed or to just use Expr.cast?
Contributor
Author
|
6891f51 to
7e28012
Compare
Member
|
So doing a little testing to see if this is necessary: Produces: So maybe we can use the existing method? |
timsaucer
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Completes a task in #463
Rationale for this change
This PR introduces the implementation of the
arrow_castfunction from datafusion's similararrow_castfunction.What changes are included in this PR?
Functionality:
Implements the arrow_cast function
Tests:
Adds a test case to validate the functionality of arrow_cast.
Are there any user-facing changes?
Yes, this PR adds the
arrow_castfunction to the API, enabling users to columns into specific data type.