Minor: Exclude all DDL statements from Ray scheduling#42
Open
ccciudatu wants to merge 1 commit intoapache:mainfrom
Open
Minor: Exclude all DDL statements from Ray scheduling#42ccciudatu wants to merge 1 commit intoapache:mainfrom
ccciudatu wants to merge 1 commit intoapache:mainfrom
Conversation
austin362667
approved these changes
Nov 12, 2024
Contributor
austin362667
left a comment
austin362667
left a comment
There was a problem hiding this comment.
Thank you!! @ccciudatu
Contributor
|
What concerns me about this change is that we had a bug that we should have prevented in unit tests. I can try to add a unit tests for this part @ccciudatu and then maybe you can fix it after I merge unit tests? |
Contributor
|
cc @andygrove |
Author
|
@edmondop any clue on what the bug was? Is it the "index out of bounds" caused by DDL statements other than crete/drop view? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not execute
EmptyExecphysical plans on the cluster, as this is the outcome of DDL statements (and it's a no-op anyway).