-
Notifications
You must be signed in to change notification settings - Fork 1.9k
doc: Add documentation for pushing limit into plan #20271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
2010YOUY01
wants to merge
2
commits into
apache:main
Choose a base branch
from
2010YOUY01:doc-limit-absorb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,47 @@ | |
|
|
||
| //! [`LimitPushdown`] pushes `LIMIT` down through `ExecutionPlan`s to reduce | ||
| //! data transfer as much as possible. | ||
| //! | ||
| //! # Plan Limit Absorption | ||
| //! In addition to pushing down [`LimitExec`] in the plan, some operators can | ||
| //! "absorb" a limit and stop early during execution. | ||
| //! | ||
| //! ## Background: vectorized volcano execution model | ||
| //! DataFusion uses a batched volcano model. For most operators, output is | ||
| //! produced in batches of `datafusion.execution.batch_size` (default 8192), so | ||
| //! the batch sizes typically look like: | ||
| //! ```text | ||
| //! 8192, 8192, ..., 8192, 100 (the final batch may be partial) | ||
| //! ``` | ||
| //! | ||
| //! ## Example | ||
| //! For a join with an expensive, selective predicate: | ||
| //! ```text | ||
| //! LimitExec(fetch=10) | ||
| //! -- NestedLoopJoinExec(on=expr_expensive_and_selective) | ||
| //! --- DataSourceExec() | ||
| //! --- DataSourceExec() | ||
| //! ``` | ||
| //! | ||
| //! Under this model, `NestedLoopJoinExec` would keep working until it can emit | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't we want to give an example with an embedded limit?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated, thanks. |
||
| //! a full batch (8192 rows), even though the query only needs 10. If the limit | ||
| //! cannot be pushed below the join, we can still embed it inside the join so it | ||
| //! stops once the limit is satisfied. The transformed plan looks like: | ||
| //! | ||
| //! ```text | ||
| //! NestedLoopJoinExec(on=expr_expensive_and_selective, fetch=10) | ||
| //! --- DataSourceExec() | ||
| //! --- DataSourceExec() | ||
| //! ``` | ||
| //! | ||
| //! ## Implementation | ||
| //! The current optimizer rule optionally pushes `fetch` requirements into | ||
| //! operators via [`ExecutionPlan::with_fetch`]. | ||
| //! | ||
| //! To support early termination in operators, [`LimitedBatchCoalescer`](https://docs.rs/datafusion/latest/datafusion/physical_plan/coalesce/struct.LimitedBatchCoalescer.html) | ||
| //! can help manage the output buffer. | ||
| //! | ||
| //! Reference implementation in Hash Join: <https://github.com/apache/datafusion/pull/20228> | ||
|
|
||
| use std::fmt::Debug; | ||
| use std::sync::Arc; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can mention that with the use of
LimitedBatchCoalescerthis can allow for passing the limit down and allowing output immediately when the limit is reached.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, updated!