-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](fe) remove deprecated version hash variables to reduce memory #59458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes deprecated version hash variables and unused methods from the FE (Frontend) catalog classes that were originally marked as deprecated in PR #8099. The cleanup improves code maintainability by removing obsolete code related to version hashing that is no longer needed.
- Removed deprecated version hash fields and their @SerializedName annotations
- Removed unused utility methods that are no longer referenced in the codebase
- Cleaned up assignments to deprecated fields in version update logic
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java | Removed deprecated checkedVersionHash field and unused methods setIdForRestore() and sortReplicaByVersionDesc() |
| fe/fe-core/src/main/java/org/apache/doris/catalog/Table.java | Removed unused hasCompoundKey and isTypeRead fields along with their getter/setter methods |
| fe/fe-core/src/main/java/org/apache/doris/catalog/Replica.java | Removed deprecated version hash fields (versionHash, lastFailedVersionHash, lastSuccessVersionHash) and cleaned up assignments to lastFailedVersionHash in version update methods |
| fe/fe-core/src/main/java/org/apache/doris/catalog/Partition.java | Removed deprecated version hash fields (committedVersionHash, visibleVersionHash, nextVersionHash) and unused method getVisibleVersionTimeIgnoreInit() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TPC-H: Total hot run time: 35644 ms |
TPC-DS: Total hot run time: 173560 ms |
ClickBench: Total hot run time: 27.3 s |
|
run cloud_p0 |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
these variables are marked as deprecated in #8099
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)