Skip to content

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Dec 29, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

these variables are marked as deprecated in #8099

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Copilot AI review requested due to automatic review settings December 29, 2025 10:22
@mymeiyi mymeiyi changed the title [fix](fe) remove deprecated version hash variables [fix](fe) remove deprecated version hash variables to reduce memory Dec 29, 2025
@mymeiyi
Copy link
Contributor Author

mymeiyi commented Dec 29, 2025

run buildall

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes deprecated version hash variables and unused methods from the FE (Frontend) catalog classes that were originally marked as deprecated in PR #8099. The cleanup improves code maintainability by removing obsolete code related to version hashing that is no longer needed.

  • Removed deprecated version hash fields and their @SerializedName annotations
  • Removed unused utility methods that are no longer referenced in the codebase
  • Cleaned up assignments to deprecated fields in version update logic

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java Removed deprecated checkedVersionHash field and unused methods setIdForRestore() and sortReplicaByVersionDesc()
fe/fe-core/src/main/java/org/apache/doris/catalog/Table.java Removed unused hasCompoundKey and isTypeRead fields along with their getter/setter methods
fe/fe-core/src/main/java/org/apache/doris/catalog/Replica.java Removed deprecated version hash fields (versionHash, lastFailedVersionHash, lastSuccessVersionHash) and cleaned up assignments to lastFailedVersionHash in version update methods
fe/fe-core/src/main/java/org/apache/doris/catalog/Partition.java Removed deprecated version hash fields (committedVersionHash, visibleVersionHash, nextVersionHash) and unused method getVisibleVersionTimeIgnoreInit()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@doris-robot
Copy link

TPC-H: Total hot run time: 35644 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 94d99f175d50276e866a2654281c9d1692b2ff5a, data reload: false

------ Round 1 ----------------------------------
q1	17665	4286	4057	4057
q2	2019	351	243	243
q3	10185	1300	744	744
q4	10235	930	322	322
q5	7507	2194	1970	1970
q6	194	173	137	137
q7	959	822	669	669
q8	9282	1436	1187	1187
q9	6603	5143	5226	5143
q10	6764	1821	1408	1408
q11	480	302	281	281
q12	711	721	599	599
q13	17760	3846	3128	3128
q14	303	300	271	271
q15	580	525	502	502
q16	710	675	643	643
q17	687	749	648	648
q18	7593	7586	7993	7586
q19	938	981	642	642
q20	446	403	284	284
q21	4581	4232	4161	4161
q22	1106	1122	1019	1019
Total cold run time: 107308 ms
Total hot run time: 35644 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4303	4212	4440	4212
q2	324	393	313	313
q3	2245	2816	2409	2409
q4	1443	1883	1433	1433
q5	4606	4245	4127	4127
q6	238	175	131	131
q7	1994	2173	1733	1733
q8	2543	2276	2399	2276
q9	7196	7127	7172	7127
q10	2489	2720	2348	2348
q11	578	477	465	465
q12	721	776	638	638
q13	3687	4135	3285	3285
q14	297	304	276	276
q15	547	492	499	492
q16	647	652	616	616
q17	1093	1326	1358	1326
q18	7308	7365	7118	7118
q19	894	859	869	859
q20	1880	1942	1793	1793
q21	4465	4378	4144	4144
q22	1128	1029	983	983
Total cold run time: 50626 ms
Total hot run time: 48104 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173560 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 94d99f175d50276e866a2654281c9d1692b2ff5a, data reload: false

query5	4386	612	448	448
query6	347	243	229	229
query7	4224	462	276	276
query8	345	249	237	237
query9	8737	2624	2637	2624
query10	505	366	326	326
query11	15199	15305	14825	14825
query12	166	117	112	112
query13	1261	486	389	389
query14	6273	2981	2750	2750
query14_1	2630	2635	2650	2635
query15	201	192	171	171
query16	1003	471	447	447
query17	1114	680	582	582
query18	2468	444	342	342
query19	234	219	196	196
query20	122	114	117	114
query21	224	141	119	119
query22	3860	3973	4011	3973
query23	15996	15494	15045	15045
query23_1	15463	15580	15325	15325
query24	7361	1589	1194	1194
query24_1	1243	1196	1217	1196
query25	578	473	422	422
query26	1252	270	165	165
query27	2757	452	293	293
query28	4514	2203	2194	2194
query29	820	591	456	456
query30	308	243	208	208
query31	755	623	565	565
query32	82	70	72	70
query33	542	338	300	300
query34	927	954	531	531
query35	747	795	711	711
query36	840	859	871	859
query37	131	97	78	78
query38	2707	2653	2643	2643
query39	774	746	723	723
query39_1	712	689	691	689
query40	216	128	111	111
query41	64	62	62	62
query42	103	104	100	100
query43	471	443	416	416
query44	1333	774	753	753
query45	185	178	176	176
query46	872	975	599	599
query47	1455	1500	1360	1360
query48	313	329	246	246
query49	604	412	324	324
query50	643	282	229	229
query51	3807	3812	3699	3699
query52	106	108	97	97
query53	295	326	273	273
query54	278	248	235	235
query55	86	75	77	75
query56	292	313	285	285
query57	1047	1023	913	913
query58	260	252	243	243
query59	2078	2051	1951	1951
query60	320	311	293	293
query61	160	160	160	160
query62	381	348	333	333
query63	297	266	279	266
query64	4978	1297	999	999
query65	3764	3711	3698	3698
query66	1430	446	308	308
query67	14696	14744	14666	14666
query68	7999	1016	730	730
query69	495	345	293	293
query70	1033	955	968	955
query71	373	295	273	273
query72	6132	4734	4901	4734
query73	707	621	317	317
query74	8730	8691	8529	8529
query75	2900	2871	2504	2504
query76	3927	1081	661	661
query77	519	374	277	277
query78	9752	9803	9094	9094
query79	1422	904	624	624
query80	647	583	476	476
query81	508	262	229	229
query82	212	144	109	109
query83	259	252	234	234
query84	252	122	112	112
query85	870	525	460	460
query86	389	294	316	294
query87	2900	2831	2750	2750
query88	3596	2309	2271	2271
query89	382	342	309	309
query90	2236	159	157	157
query91	179	156	143	143
query92	86	68	62	62
query93	1626	936	565	565
query94	578	313	298	298
query95	578	323	347	323
query96	595	487	209	209
query97	2314	2379	2273	2273
query98	224	199	192	192
query99	595	557	538	538
Total cold run time: 254431 ms
Total hot run time: 173560 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 94d99f175d50276e866a2654281c9d1692b2ff5a, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.26	0.09	0.09
query4	1.60	0.11	0.11
query5	0.28	0.26	0.27
query6	1.15	0.66	0.65
query7	0.03	0.02	0.03
query8	0.06	0.05	0.05
query9	0.56	0.48	0.49
query10	0.55	0.55	0.53
query11	0.16	0.11	0.11
query12	0.16	0.12	0.12
query13	0.62	0.60	0.60
query14	0.98	0.97	0.99
query15	0.83	0.80	0.80
query16	0.41	0.42	0.42
query17	1.00	1.01	1.00
query18	0.23	0.22	0.21
query19	1.95	1.79	1.80
query20	0.02	0.01	0.01
query21	15.44	0.29	0.14
query22	4.58	0.05	0.05
query23	16.02	0.27	0.10
query24	2.14	0.63	0.62
query25	0.12	0.06	0.06
query26	0.14	0.14	0.14
query27	0.07	0.05	0.05
query28	4.79	1.06	0.88
query29	12.59	3.98	3.15
query30	0.28	0.13	0.11
query31	2.82	0.62	0.38
query32	3.23	0.55	0.47
query33	2.94	3.04	3.02
query34	16.61	5.20	4.50
query35	4.44	4.48	4.52
query36	0.66	0.49	0.49
query37	0.11	0.07	0.06
query38	0.06	0.04	0.03
query39	0.04	0.03	0.04
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 98.41 s
Total hot run time: 27.3 s

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Dec 30, 2025

run cloud_p0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants