[hotfix][build] Update CI to support Flink 2.0#200
Open
hlteoh37 wants to merge 2 commits intoapache:mainfrom
Open
[hotfix][build] Update CI to support Flink 2.0#200hlteoh37 wants to merge 2 commits intoapache:mainfrom
hlteoh37 wants to merge 2 commits intoapache:mainfrom
Conversation
leekeiabstraction
approved these changes
Apr 16, 2025
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
Thank you for raising the PR!
Looks like the added coverage for 2.0 has found changes on the Sink interface breaking DynamoDbSink. I assume the same applies for KinesisSink as well.
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project flink-connector-dynamodb: Compilation failure: Compilation failure:
Error: /home/runner/work/flink-connector-aws/flink-connector-aws/flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSink.java:[138,13] cannot find symbol
Error: symbol: class InitContext
Error: location: class org.apache.flink.connector.dynamodb.sink.DynamoDbSink<InputT>
Error: /home/runner/work/flink-connector-aws/flink-connector-aws/flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSink.java:[137,12] cannot find symbol
Error: symbol: class StatefulSinkWriter
Error: location: class org.apache.flink.connector.dynamodb.sink.DynamoDbSink<InputT>
Error: /home/runner/work/flink-connector-aws/flink-connector-aws/flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSink.java:[145,13] cannot find symbol
Error: symbol: class InitContext
Error: location: class org.apache.flink.connector.dynamodb.sink.DynamoDbSink<InputT>
Error: /home/runner/work/flink-connector-aws/flink-connector-aws/flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSink.java:[144,12] cannot find symbol
Error: symbol: class StatefulSinkWriter
Error: location: class org.apache.flink.connector.dynamodb.sink.DynamoDbSink<InputT>
Error: /home/runner/work/flink-connector-aws/flink-connector-aws/flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DefaultDynamoDbElementConverter.java:[55,26] cannot find symbol
Error: symbol: class InitContext
Error: location: interface org.apache.flink.api.connector.sink2.Sink
Error: /home/runner/work/flink-connector-aws/flink-connector-aws/flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSinkWriter.java:[22,49] cannot find symbol
Error: symbol: class InitContext
Error: location: interface org.apache.flink.api.connector.sink2.Sink
Error: /home/runner/work/flink-connector-aws/flink-connector-aws/flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSinkWriter.java:[129,13] cannot find symbol
Error: symbol: class InitContext
Error: location: class org.apache.flink.connector.dynamodb.sink.DynamoDbSinkWriter<InputT>
Error: /home/runner/work/flink-connector-aws/flink-connector-aws/flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbBeanElementConverter.java:[67,26] cannot find symbol
Error: symbol: class InitContext
Error: location: interface org.apache.flink.api.connector.sink2.Sink
Error: /home/runner/work/flink-connector-aws/flink-connector-aws/flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSinkWriter.java:[160,5] method does not override or implement a method from a supertype
Error: -> [Help 1]
Approved. Also raised a Jira for 2.0 migration: https://issues.apache.org/jira/browse/FLINK-37687
darenwkt
reviewed
Apr 26, 2025
| matrix: | ||
| flink: [1.19-SNAPSHOT, 1.20-SNAPSHOT] | ||
| flink: [ 1.20-SNAPSHOT ] | ||
| java: [ '8, 11, 17'] |
Contributor
There was a problem hiding this comment.
Do we plan to continue supporting java 8? If not, should we remove it?
darenwkt
reviewed
Apr 26, 2025
Contributor
darenwkt
left a comment
darenwkt
left a comment
There was a problem hiding this comment.
Thanks for the PR and looking forward to support for Flink 2.0! Left a small clarification question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Support Flink 2.0 in
flink-connector-awsVerifying this change
This change is already covered by existing tests (unit test, integ test in CI)
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)
@Public(Evolving))