[FLINK-39098] Bump testcontainers to 1.21.4 for Docker API compatibility#242
Open
shivaam wants to merge 1 commit intoapache:mainfrom
Open
[FLINK-39098] Bump testcontainers to 1.21.4 for Docker API compatibility#242shivaam wants to merge 1 commit intoapache:mainfrom
shivaam wants to merge 1 commit intoapache:mainfrom
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
…r API compatibility
693fcdf to
3bbf5f6
Compare
Contributor
|
I see @ferenc-csaky already attempted this here: https://github.com/apache/flink-connector-aws/pull/232/changes but that caused the workflows to fail, can we merge this PR with that and see how we can pass the CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Bumps
testcontainersfrom1.17.2to1.21.4to resolve Docker API compatibility issues (FLINK-39098 / #232).Testcontainers 1.17.2 was released in June 2022 and does not support newer Docker API versions. Version 1.21.4 includes fixes for Docker Desktop compatibility and newer Docker Engine versions.
Verifying this change
This change is already covered by existing tests. All integration tests that exercise testcontainers pass:
flink-connector-dynamodb— DynamoDB integration tests via LocalStack containerflink-connector-aws-kinesis-streams— Kinesis Streams integration tests via LocalStack containerflink-connector-aws-kinesis-firehose— Kinesis Firehose integration tests via LocalStack containerflink-connector-sqs— SQS unit testsmvn verifypasses across all 20 modules (tested with Docker Desktop 25.0.3 on macOS ARM64)Significant changes
@Public(Evolving))