Skip to content

Conversation

@ferenc-csaky
Copy link
Contributor

What is the purpose of the change

Currently, if you try to load a CompiledPlan that contains any UDF that extends ProcessTableFunction and is not loaded already, the plan will fail to load, cause RexNodeJsonDeserializer does not know about the PROCESS_TABLE function kind.

Brief change log

  • Add PROCESS_TABLE function kind to RexNodeJsonDeserializer.
  • Provide unit tests to cover the added logic.

Verifying this change

Extended RexNodeJsonSerdeTest unit tests that covers the added logic.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@ferenc-csaky ferenc-csaky requested a review from dawidwys January 21, 2026 17:21
@flinkbot
Copy link
Collaborator

flinkbot commented Jan 21, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

}

/** Serializable process table function. */
public static class SerializableProcessTableFunction extends ProcessTableFunction<String> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems good. I am curious about the name of this class. It is possible to have a non serializable PTF? If not, I suggest naming this something like MyProcessTableFunction to prevent confusion. If we can reasonably have a non serializable PTF, we should have a test for this.

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants