-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-38953] Cleanup configurations for SSL hostname verification #27457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| /** Flag to enable/disable hostname verification for the ssl connections. */ | ||
| @Documentation.Section(Documentation.Sections.SECURITY_SSL) | ||
| public static final ConfigOption<Boolean> SSL_VERIFY_HOSTNAME = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think we should remove options. We should deprecate the old option and still allow it to work and have the documentation reference the new option as the preferred way of now doing things. Otherwise we get a failure when adopting this code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing this PR, I've tried to explain this as best as I could in the description of the PR. This configuration was not used before the mentioned PR merged yesterday. However in the ML discussion it's clear that the implementation in that PR is wrong, and we should not have hostname verification for internal communication.
There will be a migration guide probably in the release blog post that this configuration was not working properly in any other recent release, and that users should use the new configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you prefer to have it marked as deprecated, we can do that, but overall this configuration should have no effect to stay consistent with previous Flink releases.
We can note in the description that the user should use the new configuration option to have hostname verification for external connections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have re-added the old configuration as deprecated, and hidden from the docs.
3a34a45 to
b4f0e32
Compare
b4f0e32 to
c22362f
Compare
What is the purpose of the change
As described in this ML thread, the SSL endpoint verification configuration is not working as expected. This was mitigated in #27407 but the change in that PR enables endpoint verification for internal communication as well.
This PR will address that according to the ML thread, and only REST client will use hostname verification using the new configuration.
Brief change log
security.ssl.verify-hostnamewhich is not used in any recent released Flink versionsecurity.ssl.rest.verify-hostnamewhich will only add hostname verification for REST connectionsVerifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation