Skip to content

Conversation

@Myracle
Copy link
Contributor

@Myracle Myracle commented Jan 22, 2026

What is the purpose of the change

Add log to show whether PYFLINK_CYTHON_ENABLED is set

Brief change log

  • Add log to show whether PYFLINK_CYTHON_ENABLED is set and show related info.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 22, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

if not PYFLINK_CYTHON_ENABLED:
_LOG.info("PYFLINK_CYTHON_ENABLED is set to False via environment variable.")
else:
PYFLINK_CYTHON_ENABLED = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean that if the environment variable is not specified we set it to True. If we want True to be the default, then would it not be clearer to set it to True prior to the if.

import os

_LOG = logging.getLogger(__name__)

Copy link
Contributor

@davidradl davidradl Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add tests for the logic you have added please.

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants