[FLINK-38783][runtime] Improved TieredStorageResourceRegistry Thread-Safety/Concurrency #27459
+205
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request addresses the issue detailed in FLINK-38783 which detailed how the registration process within
TieredStorageResourceRegistrywas not properly handling concurrent operations and as such could throw aConcurrentModificationExceptionunder concurrent load.Brief change log
registeredResourcesgeneral-purpose hash map (Map<..., List<...>>) with corresponding thread-safe structures (ConcurrentHashMap<..., CopyOnWriteArrayList<...>>) to better handle concurrent operations.Verifying this change
This change added a series of tests in
TieredStorageResourceRegistryTestto originally reproduce the issue and later confirm the fix worked as expected including:testConcurrentRegisterResourceto test concurrent resource registration across separate threads (10 total with same owner/identifier)testConcurrentRegisterResourceWithDifferentOwnersto test concurrent registration across separate threads (10 total with different owners/identifiers)testConcurrentRegisterAndClearto test concurrent registration and clearing across separate threadsExample Tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation