Skip to content

Conversation

@snuyanzin
Copy link
Contributor

What is the purpose of the change

This method was introduced in FLINK-26460 (Calcite 1.26)
Since then we bumped Calcite 10 versions up (now it is 1.36)
the problem is fixed in Calcite

Verifying this change

Existing tests added within FLINK-26460

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

}

private SqlNode maybeCast(SqlNode node, RelDataType currentType, RelDataType desiredType) {
protected SqlNode maybeCast(SqlNode node, RelDataType currentType, RelDataType desiredType) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change has already been committed to Calcite and will come with future updates
apache/calcite@f6271b7

@snuyanzin snuyanzin changed the title [FLINK-38964][table] Reuse Calcite's SlqValidatorImpl#maybeCast [FLINK-38964][table] Reuse Calcite's SqlValidatorImpl#maybeCast Jan 22, 2026
@flinkbot
Copy link
Collaborator

flinkbot commented Jan 22, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants