[FLINK-40034][runtime-web] Refresh web-dashboard lint tooling to prettier 3 and stylelint 17#28710
Open
spuru9 wants to merge 2 commits into
Open
[FLINK-40034][runtime-web] Refresh web-dashboard lint tooling to prettier 3 and stylelint 17#28710spuru9 wants to merge 2 commits into
spuru9 wants to merge 2 commits into
Conversation
… to 5, stylelint to 17
Refreshes the web-dashboard lint tooling: prettier 2->3, eslint-plugin-prettier
4->5, stylelint 14->17 with its config cascade (stylelint-config-standard 40,
stylelint-config-hudochenkov 13, stylelint-prettier 5), and drops the now-
unused stylelint-config-prettier (unsupported past stylelint 14, redundant
since standard config 40 no longer ships the stylistic rules it used to
disable).
stylelint-config-standard 40 adds several CSS-only rules that misfire on
Less syntax, so they're disabled/adjusted in .stylelintrc.js:
- declaration-property-value-no-unknown, declaration-property-value-keyword-
no-deprecated: Less-specific values otherwise flagged as unknown.
- import-notation set to 'string': the default 'url' rewrites
`@import "x"` to `@import url("x")`, which breaks Less inlining.
- color-function-alias-notation: disabled because rewriting rgba(...) to a
4-arg rgb(...) is valid modern CSS but Less's built-in rgb() function only
accepts 3 args, silently dropping the alpha channel at compile time.
Generated-by: Claude Code (claude-sonnet-5)
… fixes Mechanical output of \`npm run lint:fix\` after the prettier/stylelint bump, isolated from the dependency/config change so the formatting-only diff is easy to review on its own. Constructor parameter wrapping, lowercase doctype, and a few Less property reorderings/shorthands (top/right/bottom/left -> inset); no behavioral changes. Generated-by: Claude Code (claude-sonnet-5)
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Bring the web-dashboard lint tooling current, per FLINK-40034:
stylelint-config-hudochenkov -> 13, stylelint-prettier -> 5; drops the
now-unused (and stylelint-17-incompatible) stylelint-config-prettier
Jira: https://issues.apache.org/jira/browse/FLINK-40034
Brief change log
package.json.stylelint-config-standard40 adds several CSS-only rules that misfire on Less syntax, so.stylelintrc.jsdisables/adjusts them:declaration-property-value-no-unknown,declaration-property-value-keyword-no-deprecated: otherwise flag valid Less-specific values as unknown.import-notation: 'string': the default'url'rewrites@import "x"to@import url("x"), which breaks Less inlining.color-function-alias-notation: disabled after discovering it rewritesrgba(...)to a 4-argumentrgb(...), which is valid modern CSS but silently drops the alpha channel when compiled through Less's built-in 3-argumentrgb()function (verified via a production build:rgba(0, 0, 0, 0.8)compiled to opaque#000before this fix).npm run lint:fixand committed the resulting mechanical formatting diff (constructor parameter wrapping, lowercasedoctype, a few Less property reorderings/shorthands) as a separate, isolated commit for easy review.Angular's new built-in control-flow syntax (
@if/@for) is not used anywhere in this codebase yet (still on*ngIf/*ngFor); that migration is deferred to a dedicated follow-up, per the existing comment ineslint.config.js. This PR only lands the tooling/config prerequisites.Verifying this change
npm run lint(cold cache) passes cleanly.npm run buildsucceeds; confirmed via the compiled CSS output that thecolor-function-alias-notationfix preserves the alpha channel (rgba(0,0,0,0.8)compiles to#000c, not opaque#000).npm run ci-checkpasses end-to-end.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?