[FLINK-40118][runtime-web] Use REST endpoint field instead of removed host field#28712
Open
spuru9 wants to merge 1 commit into
Open
[FLINK-40118][runtime-web] Use REST endpoint field instead of removed host field#28712spuru9 wants to merge 1 commit into
spuru9 wants to merge 1 commit into
Conversation
… host field FLINK-36355 removed the deprecated `host` field from the REST API's subtask-level responses, keeping only `endpoint`, but the web-dashboard frontend was never updated. The SubTask TimeLine and the SubTask Accumulators table each read `task.host`, which is now always undefined, so their subtask rows render as "N - undefined" instead of showing the TaskManager endpoint. Update the two frontend interfaces (JobSubTaskTime, SubTaskAccumulators) and their consuming components to read `endpoint` instead of `host`. Generated-by: Claude Code (claude-opus-4-8)
Collaborator
Contributor
Author
|
@RocMarshal @och5351 Can you help me review/merge this minor fix. |
RocMarshal
reviewed
Jul 12, 2026
Contributor
Author
This PR only touches frontend TypeScript/HTML files (interfaces + two components) — no Java/REST API code at all. It is in response to the breaking change long back in FLINK-36355 / #25436, merged 2024-10-01, well before Flink 2.0 shipped. |
Contributor
|
Thanks @spuru9 for the confirmation. Attributed to the latest version of 2.x is 2.3, which means more than 2 editions in distance to 2.0. |
Contributor
Author
|
It would need any backport? Considering it had been there for a long time, should be fine. |
Contributor
|
Nice idea. |
Contributor
Author
Yes sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The job Timeline tab's SubTask view and the SubTask Accumulators table both render
N - undefinedinstead of the TaskManager location for each subtask.Brief change log
hostfield from the REST API's subtask-level responses (SubtasksTimesInfo,SubtaskExecutionAttemptDetailsInfo,SubtasksAllAccumulatorsInfo), keeping onlyendpoint. That PR ([FLINK-36355][runtime] Remove deprecated REST APIs #25436) touched only backend Java classes; the web-dashboard frontend was never updated to match, sotask.hosthas readundefinedsince Flink 2.0.JobSubTaskTime(job-timeline.ts) andSubTaskAccumulators(job-accumulators.ts) to declareendpointinstead ofhost.job-timeline.component.ts(SubTask TimeLine chart labels) andjob-overview-drawer-accumulators.component.html(SubTask Accumulators table) — to readtask.endpoint/subTaskAccumulator.endpoint.Verifying this change
npm run lintandnpm run buildpass.0 - undefined; after the fix, it shows0 - localhost:<port>.Before:
After:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
AI Usage Disclosure