[python] Prevent Beam state access after runner shutdown#28716
Draft
bowenli86 wants to merge 1 commit into
Draft
[python] Prevent Beam state access after runner shutdown#28716bowenli86 wants to merge 1 commit into
bowenli86 wants to merge 1 commit into
Conversation
Generated-by: Codex GPT-5
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change\n\nThis change prevents Beam state requests from accessing Flink state after Python runner shutdown has completed. During task cancellation, Beam state callbacks can otherwise overlap keyed state backend disposal and access closed RocksDB native resources.\n\n## Brief change log\n\n- Add a lifecycle gate to BeamStateRequestHandler.\n- Wait for in-flight state requests during close and reject requests after close.\n- Close the state handler after Beam request production stops and before the Python runner returns.\n- Add deterministic tests for close draining, post-close rejection, and runner shutdown ordering.\n\n## Verifying this change\n\nThis change added tests and can be verified as follows:\n\n- ./mvnw -q -pl flink-python -am -Dflink.markBundledAsOptional=false -Dtest=BeamStateRequestHandlerTest,BeamPythonFunctionRunnerTest -Dsurefire.failIfNoSpecifiedTests=false -Dfast -Pskip-webui-build -T1 test\n- ./mvnw -f flink-python/pom.xml spotless:check\n- ./mvnw -f flink-python/pom.xml checkstyle:check\n\n## Does this pull request potentially affect one of the following parts:\n\n- Dependencies (does it add or upgrade a dependency): no\n- The public API, i.e., is any changed class annotated with @public(Evolving): no\n- The serializers: no\n- The runtime per-record code paths (performance sensitive): yes\n- Anything that affects deployment or recovery: yes\n- The S3 file system connector: no\n\n## Documentation\n\n- Does this pull request introduce a new feature? no\n- If yes, how is the feature documented? not applicable\n\n---\n\n##### Was generative AI tooling used to co-author this PR?\n\n- [X] Yes (Codex GPT-5)\n\nGenerated-by: Codex GPT-5