[FLINK-40122][table] Expose a public getter for the persisted RowData field names#28718
Closed
weiqingy wants to merge 2 commits into
Closed
[FLINK-40122][table] Expose a public getter for the persisted RowData field names#28718weiqingy wants to merge 2 commits into
weiqingy wants to merge 2 commits into
Conversation
…Snapshot Add the top-level field names to RowDataSerializerSnapshot so they survive a save/restore round-trip, as shared infrastructure for schema-aware consumers. The names are written unconditionally and the change is behavior-neutral: no compatibility or evolution logic is added. The snapshot format moves V3 to V4; V4 readers still read V3 snapshots (names absent -> null), so existing savepoints continue to restore. Generated-by: Claude Code (Claude Opus 4.8)
… field names Add a public getter on RowDataSerializerSnapshot that returns the top-level RowData field names persisted by FLINK-40120, so external consumers such as the State Catalog can read them. Returns null for legacy snapshots (version 3 and earlier) written before field-name persistence. No format or behavior change: the getter only exposes the already-persisted names; the wire format, compatibility resolution, and equality are unchanged. Generated-by: Claude Code (Claude Opus 4.8)
Collaborator
Author
|
Closing for now — this stacks on #28717 (FLINK-40120), so the diff here includes that PR's changes. I'll open the getter as a clean PR once #28717 merges; it's tracked by sub-task FLINK-40122. Branch and commit are preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request adds a public getter on
RowDataSerializerSnapshotthat returns the top-levelRowDatafield names persisted by FLINK-40120, so external consumers can read them. It returnsnullfor legacy snapshots (version 3 and earlier) written before field-name persistence.Note: this PR stacks on #28717 (FLINK-40120), which is under review. Until #28717 merges, the diff here also contains its changes; the net-new change in this PR is the single public getter (see the latest commit). It will be rebased onto a clean master once #28717 merges.
Brief change log
public @Nullable String[] getFieldNames()onRowDataSerializerSnapshot, returning the persisted top-level field names (nullfor legacy version-3-and-earlier snapshots).Verifying this change
This change added tests and can be verified as follows:
snapshotPublicGetterReturnsPersistedNames— a snapshot taken from a named serializer returns the top-level names through the public getter.getFieldNames()returnsnull.Does this pull request potentially affect one of the following parts:
@Public(Evolving): no — the getter is onRowDataSerializerSnapshot, whose enclosingRowDataSerializeris@InternalRowDataSerializerSnapshot; no change to the serialization format or behaviorDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 4.8)