[FLUSS] Add AggMode support for undo recovery in aggregation tables #2492
+1,191
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces AggMode (Aggregation Mode) to control how the server handles data aggregation when writing to tables with aggregation merge engine. Key changes: 1. New AggMode enum with three modes: - AGGREGATE (default): Data is aggregated through server-side merge engine - OVERWRITE: Bypass merge engine, directly replace values (for undo recovery) - LOCAL_AGGREGATE: Reserved for future client-side pre-aggregation 2. Client-side changes: - Upsert interface: Added aggregationMode(AggMode) method for fluent API - UpsertWriterImpl: Propagates aggMode through WriteRecord - KvWriteBatch: Validates aggMode consistency within batch - ClientRpcMessageUtils: Validates aggMode consistency across batches - WriteRecord: Added aggMode field for upsert/delete operations 3. Server-side changes: - KvTablet: Pre-creates overwriteRowMerger for OVERWRITE mode - putAsLeader(): Selects appropriate RowMerger based on aggMode - Replica/ReplicaManager: Propagates aggMode through call chain - TabletService: Extracts aggMode from PutKvRequest 4. Protocol changes: - FlussApi.proto: Added optional agg_mode field to PutKvRequest 5. Test coverage: - KvTabletAggModeTest: 9 tests covering OVERWRITE mode scenarios - KvWriteBatchTest: 3 tests for aggMode consistency validation - ClientRpcMessageUtilsTest: 4 tests for multi-batch aggMode validation This feature enables Flink connector to perform undo recovery by restoring exact historical values during checkpoint failover, bypassing the merge engine.
platinumhamburg
force-pushed
the
agg-mode
branch
from
8e06337 to
cda0697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces AggMode (Aggregation Mode) to control how the server handles data aggregation when writing to tables with aggregation merge engine.
Key changes:
New AggMode enum with three modes:
Client-side changes:
Server-side changes:
Protocol changes:
Test coverage:
This feature enables Flink connector to perform undo recovery by restoring exact historical values during checkpoint failover, bypassing the merge engine.
Purpose
Linked issue: close #2491 2491
Brief change log
Tests
API and Format
Documentation