Skip to content

fix(ci): replace make with ninja.#885

Merged
yangxk1 merged 5 commits intoapache:mainfrom
SYaoJun:227_ninja
Mar 2, 2026
Merged

fix(ci): replace make with ninja.#885
yangxk1 merged 5 commits intoapache:mainfrom
SYaoJun:227_ninja

Conversation

@SYaoJun
Copy link
Contributor

@SYaoJun SYaoJun commented Feb 27, 2026

Reason for this PR

fix: #884

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Signed-off-by: syaojun <libevent@yeah.net>
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.86%. Comparing base (0042a6c) to head (d1c1e5a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #885      +/-   ##
============================================
+ Coverage     79.84%   79.86%   +0.02%     
  Complexity      615      615              
============================================
  Files            93       93              
  Lines         10310    10296      -14     
  Branches       1055     1055              
============================================
- Hits           8232     8223       -9     
+ Misses         1838     1833       -5     
  Partials        240      240              
Flag Coverage Δ
cpp 70.89% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: syaojun <libevent@yeah.net>
Signed-off-by: syaojun <libevent@yeah.net>
@SYaoJun
Copy link
Contributor Author

SYaoJun commented Feb 27, 2026

ninja almost faster than make approximately 10%~30%.

@SYaoJun
Copy link
Contributor Author

SYaoJun commented Feb 27, 2026

MacOS cost 7m 58s.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the C++ CI workflows to use the Ninja generator instead of GNU Make, addressing macOS failures caused by the Linux-only nproc usage in parallel Make builds (issue #884).

Changes:

  • Install Ninja on Ubuntu CI runners (ninja-build) and macOS via Homebrew (ninja).
  • Switch CMake configuration in CI to -G Ninja and replace make invocations with ninja.
  • Update lint/docs build steps in CI to run their targets via Ninja.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
cpp/Brewfile Adds ninja so macOS CI (via brew bundle) has the required build tool.
.github/workflows/ci.yml Installs Ninja on Ubuntu and switches configure/build/lint/docs steps from Make to Ninja across Ubuntu + macOS jobs.
.github/workflows/ci-nightly.yml Installs Ninja and switches nightly configure/build steps from Make to Ninja.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SYaoJun
Copy link
Contributor Author

SYaoJun commented Feb 28, 2026

It appears Copilot does not provide any additional suggestions. @yangxk1

Copy link
Contributor

@yangxk1 yangxk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ninja looks good! but I think we should also keep a make case to ensure that make works fine

SYaoJun added 2 commits March 1, 2026 10:04
Signed-off-by: syaojun <libevent@yeah.net>
Signed-off-by: syaojun <libevent@yeah.net>
@SYaoJun SYaoJun requested a review from yangxk1 March 2, 2026 04:43
Copy link
Contributor

@yangxk1 yangxk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangxk1 yangxk1 merged commit 83b44b1 into apache:main Mar 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] MacOS does not compile in parallel

4 participants