Conversation
Signed-off-by: syaojun <libevent@yeah.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
============================================
+ Coverage 79.84% 79.86% +0.02%
Complexity 615 615
============================================
Files 93 93
Lines 10310 10296 -14
Branches 1055 1055
============================================
- Hits 8232 8223 -9
+ Misses 1838 1833 -5
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: syaojun <libevent@yeah.net>
Signed-off-by: syaojun <libevent@yeah.net>
|
ninja almost faster than make approximately 10%~30%. |
|
MacOS cost 7m 58s. |
There was a problem hiding this comment.
Pull request overview
Updates the C++ CI workflows to use the Ninja generator instead of GNU Make, addressing macOS failures caused by the Linux-only nproc usage in parallel Make builds (issue #884).
Changes:
- Install Ninja on Ubuntu CI runners (
ninja-build) and macOS via Homebrew (ninja). - Switch CMake configuration in CI to
-G Ninjaand replacemakeinvocations withninja. - Update lint/docs build steps in CI to run their targets via Ninja.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cpp/Brewfile |
Adds ninja so macOS CI (via brew bundle) has the required build tool. |
.github/workflows/ci.yml |
Installs Ninja on Ubuntu and switches configure/build/lint/docs steps from Make to Ninja across Ubuntu + macOS jobs. |
.github/workflows/ci-nightly.yml |
Installs Ninja and switches nightly configure/build steps from Make to Ninja. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
It appears Copilot does not provide any additional suggestions. @yangxk1 |
yangxk1
left a comment
There was a problem hiding this comment.
Using ninja looks good! but I think we should also keep a make case to ensure that make works fine
Signed-off-by: syaojun <libevent@yeah.net>
Signed-off-by: syaojun <libevent@yeah.net>
Reason for this PR
fix: #884
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?