feat(cpp): improve CMake configuration for portable distribution and installation (#810)#890
Open
shivendra-dev54 wants to merge 1 commit intoapache:mainfrom
Open
feat(cpp): improve CMake configuration for portable distribution and installation (#810)#890shivendra-dev54 wants to merge 1 commit intoapache:mainfrom
shivendra-dev54 wants to merge 1 commit intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
============================================
+ Coverage 79.81% 79.86% +0.04%
Complexity 615 615
============================================
Files 93 93
Lines 10296 10296
Branches 1055 1055
============================================
+ Hits 8218 8223 +5
+ Misses 1838 1833 -5
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@yangxk1 |
Contributor
|
cc @Sober7135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
This PR addresses #810 to improve the portability and installation of the GraphAr C++ library. The current setup makes it difficult for downstream projects to use
find_package(graphar), which this update resolves by modernizing the CMake export logic.What changes are included in this PR?
graphar::grapharnamespace viainstall(EXPORT).PUBLICvisibility to ensure proper propagation to consumers.GNUInstallDirsfor standard-compliant paths.CMAKE_INSTALL_RPATHusing$ORIGIN(Linux) and@loader_path(macOS) to ensure the library is relocatable.graphar-config.in.cmakeusing@PACKAGE_INIT@andfind_dependencyfor robust downstream resolution.GRAPHAR_LIBRARIESandGRAPHAR_INCLUDE_DIRvariables.Are these changes tested?
ctest).make installgenerates a valid relocatable file structure.find_package(graphar REQUIRED).Are there any user-facing changes?
Yes. Users can now integrate GraphAr into their own projects using the standard CMake pattern: