fix(cpp): remove UB when reading unset builder vertex id#892
Open
Sober7135 wants to merge 2 commits intoapache:mainfrom
Open
fix(cpp): remove UB when reading unset builder vertex id#892Sober7135 wants to merge 2 commits intoapache:mainfrom
Sober7135 wants to merge 2 commits intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
============================================
+ Coverage 79.81% 79.87% +0.05%
Complexity 615 615
============================================
Files 93 93
Lines 10296 10296
Branches 1055 1055
============================================
+ Hits 8218 8224 +6
+ Misses 1838 1832 -6
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
#846
What changes are included in this PR?
builder::Vertexid asstd::optional<IdType>instead of an uninitialized scalarGetId()fail explicitly when the id is unset, instead of reading uninitialized memoryempty_flag frombuilder::VertexEmpty()fromproperties_.empty()so vertex emptiness is no longer tracked by redundant mutable stateSetId()/ constructor-initialized id behaviorEmpty()behavior after removing the storedempty_fieldAre these changes tested?
Yes
Are there any user-facing changes?
Yes